Closed Bug 1843262 Opened 2 years ago Closed 2 years ago

Add logging presets to profiler

Categories

(Core :: Networking, task, P2)

task

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: kershaw, Assigned: dotoole)

Details

(Whiteboard: [necko-triaged][necko-priority-queue])

Attachments

(1 file)

We've added logging prefets in bug 1838211, but it only works for files.
It'd be great if we can make gecko profiler also use these presets.

Assignee: nobody → dotoole
Whiteboard: [necko-triaged] [necko-priority-next] → [necko-triaged][necko-priority-queue]

Hey Dylan, Kershaw,
Instead of adding new profiler presets, you can instruct your about:logging presets to use the already existing "Networking" preset, by specifying profilerPreset: "networking" for this about:logging presets. Would that work well enough for you?

That would also prevent the cluttering of our main preset selection.

Flags: needinfo?(kershaw)
Flags: needinfo?(dotoole)

(In reply to Julien Wajsberg [:julienw] from comment #2)

Hey Dylan, Kershaw,
Instead of adding new profiler presets, you can instruct your about:logging presets to use the already existing "Networking" preset, by specifying profilerPreset: "networking" for this about:logging presets. Would that work well enough for you?

I believe this should be enough, but as I am not completely familiar with the profiler code, I am not certain. I will leave it to Dylan to determine the best approach. Thank you.

Flags: needinfo?(kershaw)

I agree with Kershaw, that seems to be enough thanks!

Flags: needinfo?(dotoole)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: