1843298 - Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:110:27 in get

Status: RESOLVED DUPLICATE of bug 1840918

(Core :: Storage: IndexedDB, defect)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=422521220&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aB8aPVQCSK2IPBLzHO8oBw/runs/0/artifacts/public/logs/live_backing.log

---

TEST-PASS | toolkit/components/terminator/tests/xpcshell/test_terminator_reload.js | took 4495ms
[task 2023-07-13T12:46:38.147Z] 12:46:38     INFO -  Retrying tests that failed when run in parallel.
[task 2023-07-13T12:46:38.148Z] 12:46:38     INFO -  TEST-START | security/manager/ssl/tests/unit/test_forget_about_site_security_headers.js
[task 2023-07-13T12:46:39.705Z] 12:46:39  WARNING -  TEST-UNEXPECTED-FAIL | security/manager/ssl/tests/unit/test_forget_about_site_security_headers.js | xpcshell return code: -6
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  TEST-INFO took 1555ms
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  >>>>>>>
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  running event loop
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  security/manager/ssl/tests/unit/test_forget_about_site_security_headers.js | Starting
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  (xpcshell/head.js) | test pending (2)
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  TEST-PASS | security/manager/ssl/tests/unit/test_forget_about_site_security_headers.js |  - a.pinning.example.com should be HSTS - true == true
[task 2023-07-13T12:46:39.705Z] 12:46:39     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2023-07-13T12:46:39.706Z] 12:46:39     INFO -  PID 27290 | ==================
[task 2023-07-13T12:46:39.706Z] 12:46:39     INFO -  PID 27290 | WARNING: ThreadSanitizer: data race (pid=27290)
[task 2023-07-13T12:46:39.707Z] 12:46:39     INFO -  PID 27290 |   Read of size 8 at 0x7f090bc1c598 by thread T21:
[task 2023-07-13T12:46:39.708Z] 12:46:39     INFO -  PID 27290 |     #0 get /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:110:27 (libxul.so+0x7b63d66) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.708Z] 12:46:39     INFO -  PID 27290 |     #1 operator mozilla::dom::IndexedDatabaseManager * /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:112:32 (libxul.so+0x7b63d66)
[task 2023-07-13T12:46:39.709Z] 12:46:39     INFO -  PID 27290 |     #2 mozilla::dom::IndexedDatabaseManager::Get() /builds/worker/checkouts/gecko/dom/indexedDB/IndexedDatabaseManager.cpp:257:10 (libxul.so+0x7b63d66)
[task 2023-07-13T12:46:39.710Z] 12:46:39     INFO -  PID 27290 |     #3 mozilla::dom::indexedDB::(anonymous namespace)::QuotaClient::OnRepositoryClearCompleted(mozilla::dom::quota::PersistenceType) /builds/worker/checkouts/gecko/dom/indexedDB/ActorsParent.cpp:12399:37 (libxul.so+0x7af6036) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.711Z] 12:46:39     INFO -  PID 27290 |     #4 mozilla::dom::quota::QuotaManager::RepositoryClearCompleted(mozilla::dom::quota::PersistenceType) /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:5327:24 (libxul.so+0x7877c48) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.711Z] 12:46:39     INFO -  PID 27290 |     #5 mozilla::dom::quota::(anonymous namespace)::ClearPrivateRepositoryOp::DoDirectoryWork(mozilla::dom::quota::QuotaManager&) /builds/worker/checkouts/gecko/dom/quota/OriginOperations.cpp:745:17 (libxul.so+0x78b2648) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.712Z] 12:46:39     INFO -  PID 27290 |     #6 mozilla::dom::quota::OriginOperationBase::DirectoryWork() /builds/worker/checkouts/gecko/dom/quota/OriginOperationBase.cpp:123:3 (libxul.so+0x789b4ad) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.713Z] 12:46:39     INFO -  PID 27290 |     #7 mozilla::dom::quota::OriginOperationBase::Run() /builds/worker/checkouts/gecko/dom/quota/OriginOperationBase.cpp:39:12 (libxul.so+0x789b32d) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.714Z] 12:46:39     INFO -  PID 27290 |     #8 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1193:16 (libxul.so+0x3b8ae3c) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.714Z] 12:46:39     INFO -  PID 27290 |     #9 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:480:10 (libxul.so+0x3b91186) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.715Z] 12:46:39     INFO -  PID 27290 |     #10 mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:300:20 (libxul.so+0x468460e) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.716Z] 12:46:39     INFO -  PID 27290 |     #11 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:370:10 (libxul.so+0x45fdfe8) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.717Z] 12:46:39     INFO -  PID 27290 |     #12 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:363:3 (libxul.so+0x45fdfe8)
[task 2023-07-13T12:46:39.717Z] 12:46:39     INFO -  PID 27290 |     #13 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:345:3 (libxul.so+0x45fdfe8)
[task 2023-07-13T12:46:39.718Z] 12:46:39     INFO -  PID 27290 |     #14 nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:391:10 (libxul.so+0x3b868d9) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.719Z] 12:46:39     INFO -  PID 27290 |     #15 _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5 (libnspr4.so+0x4de89) (BuildId: ed5e5e1daf5bff2feeb21d2e4e15f71a1c375a05)
[task 2023-07-13T12:46:39.720Z] 12:46:39     INFO -  PID 27290 |   Previous write of size 8 at 0x7f090bc1c598 by main thread:
[task 2023-07-13T12:46:39.720Z] 12:46:39     INFO -  PID 27290 |     #0 AssignAssumingAddRef /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:131:13 (libxul.so+0x7b63759) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.721Z] 12:46:39     INFO -  PID 27290 |     #1 AssignWithAddref /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:126:5 (libxul.so+0x7b63759)
<...>
INFO -  PID 27290 |     #78 main /builds/worker/checkouts/gecko/js/xpconnect/shell/xpcshell.cpp:81:27 (xpcshell+0x133bc0) (BuildId: 77bdf774f24d267903168f5f1e34bda2e38585b1)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |   Location is global 'mozilla::dom::(anonymous namespace)::gDBManager' of size 8 at 0x7f090bc1c598 (libxul.so+0xd4b7598)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |   Thread T21 'QuotaManager IO' (tid=27312, running) created by thread T5 at:
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #0 pthread_create /builds/worker/fetches/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1048:3 (xpcshell+0xab6fb) (BuildId: 77bdf774f24d267903168f5f1e34bda2e38585b1)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #1 _PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:458:14 (libnspr4.so+0x4509e) (BuildId: ed5e5e1daf5bff2feeb21d2e4e15f71a1c375a05)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #2 PR_CreateThread /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:533:12 (libnspr4.so+0x3a124) (BuildId: ed5e5e1daf5bff2feeb21d2e4e15f71a1c375a05)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #3 nsThread::Init(nsTSubstring<char> const&) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:634:18 (libxul.so+0x3b881a5) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #4 nsThreadManager::NewNamedThread(nsTSubstring<char> const&, nsIThreadManager::ThreadCreationOptions, nsIThread**) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadManager.cpp:550:12 (libxul.so+0x3b8fddf) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #5 NS_NewNamedThread(nsTSubstring<char> const&, nsIThread**, already_AddRefed<nsIRunnable>, nsIThreadManager::ThreadCreationOptions) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:176:57 (libxul.so+0x3b98786) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.754Z] 12:46:39     INFO -  PID 27290 |     #6 NS_NewNamedThread<16UL> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:87:10 (libxul.so+0x7853887) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #7 operator()<const char (&)[16], nsGetterAddRefs<nsIThread> > /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2176:3 (libxul.so+0x7853887)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #8 ToResultInvokeInternal<nsCOMPtr<nsIThread>, nsresult, (lambda at /builds/worker/workspace/obj-build/dist/include/mozilla/ResultExtensions.h:140:14), (lambda at /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2176:3), const char (&)[16]> /builds/worker/workspace/obj-build/dist/include/mozilla/ResultExtensions.h:96:17 (libxul.so+0x7853887)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #9 ToResultInvokeSelector<nsCOMPtr<nsIThread>, nsresult, (lambda at /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2176:3), const char (&)[16]> /builds/worker/workspace/obj-build/dist/include/mozilla/ResultExtensions.h:139:10 (libxul.so+0x7853887)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #10 ToResultInvoke<nsCOMPtr<nsIThread>, nsresult, (lambda at /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2176:3), const char (&)[16]> /builds/worker/workspace/obj-build/dist/include/mozilla/ResultExtensions.h:173:10 (libxul.so+0x7853887)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #11 mozilla::dom::quota::QuotaManager::Init() /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:2176:3 (libxul.so+0x7853887)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #12 mozilla::dom::quota::QuotaManager::GetOrCreate() /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:1790:3 (libxul.so+0x7852916) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #13 mozilla::dom::quota::QuotaManager::EnsureCreated() /builds/worker/checkouts/gecko/dom/quota/ActorsParent.cpp:1804:3 (libxul.so+0x78545b0) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #14 mozilla::dom::quota::Quota::AllocPQuotaRequestParent(mozilla::dom::quota::RequestParams const&) /builds/worker/checkouts/gecko/dom/quota/QuotaParent.cpp:352:3 (libxul.so+0x78abbd1) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #15 mozilla::dom::quota::PQuotaParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PQuotaParent.cpp:357:50 (libxul.so+0x78cdd86) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #16 mozilla::ipc::PBackgroundParent::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBackgroundParent.cpp:3048:32 (libxul.so+0x46dcb7c) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #17 mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1811:25 (libxul.so+0x467f9cf) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #18 mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message>>) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1736:9 (libxul.so+0x467e0c8) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #19 mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1536:3 (libxul.so+0x467e6d3) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.755Z] 12:46:39     INFO -  PID 27290 |     #20 mozilla::ipc::MessageChannel::MessageTask::Run() /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1634:14 (libxul.so+0x467f017) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #21 nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1193:16 (libxul.so+0x3b8ae3c) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #22 NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:480:10 (libxul.so+0x3b91186) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #23 mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:300:20 (libxul.so+0x468465e) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #24 RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:370:10 (libxul.so+0x45fdfe8) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #25 RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:363:3 (libxul.so+0x45fdfe8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #26 MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:345:3 (libxul.so+0x45fdfe8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #27 nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:391:10 (libxul.so+0x3b868d9) (BuildId: 6db27aa1476a04fea621516c20474a280585d2f8)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 |     #28 _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5 (libnspr4.so+0x4de89) (BuildId: ed5e5e1daf5bff2feeb21d2e4e15f71a1c375a05)
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 | SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/mozilla/StaticPtr.h:110:27 in get
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  PID 27290 | ==================
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  <<<<<<<
[task 2023-07-13T12:46:39.756Z] 12:46:39     INFO -  TEST-START | netwerk/test/unit/test_http3_early_hint_listener.js

Comment 1

[Andrew McCreight [:mccr8]]

Looks like a race on gDBManager in IndexedDatabaseManager.cpp, which is a StaticRefPtr, so this is related to bug 1841706. It isn't as bad as that, because the creation only happens on the main thread, but it is as least an instance of the value being retrieved in a racy fashion from another thread.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: full TSan report

Here's the full TSan report extracted from the log.

Comment 4

[mozillabugs]

Hi Sebastian. Please add me to the CC list for https://bugzilla.mozilla.org/show_bug.cgi?id=1840918 . Thanks.

Comment 5

[Andrew McCreight [:mccr8]]

Done