1843328 - event listener badge is not marked up as a button

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1843328 - [devtools] Turn interactive markup view badges into proper buttons. r=#devtools-reviewers.

For the badges that act as toggles (e.g. the display badge for toggling flex/grid highlighters),
we also set aria-pressed buttons.

Tests are added in the next patch of this stack.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0dad4ea4f16
[devtools] Turn interactive markup view badges into proper buttons. r=devtools-reviewers,ochameau.

Comment 4

[Cristina Horotan [:chorotan]]

Backed out 2 changesets (bug 1843328, bug 1843330) for causing dt failures at browser_markup_events-windowed-host.js

Backout: https://hg.mozilla.org/integration/autoland/rev/8ed5c72382329b9cdd8e3c952a9e35faa4688599

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fda104236c8ffa25c66ab687523758fb6b072d9c&selectedTaskRun=UXzbDnvqRE-7xzblpl2FFw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=431255162&repo=autoland&lineNumber=8453

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bb74e755943
[devtools] Turn interactive markup view badges into proper buttons. r=devtools-reviewers,ochameau.

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4bb74e755943