1843601 - Bookmark stars are misaligned when browser.urlbar.richSuggestions.featureGate is set to true

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[aoia7rz7l]

Tested on 117.0a1 (2023-07-13) BuildID 20230713214846.

STR:

1. Type mozilla in the address bar.
2. Note the position of all bookmark stars relative to the favicon for each result.

Expected Behavior:

Bookmark stars for bookmarked sites should be located at the bottom right of favicons.

Actual Behavior:
Bookmark stars for bookmarked sites are misaligned.

Mozregression returned

Last good revision: 8bed6ab81a11bda3f3d3a4e4d9239f901d899a6d
First bad revision: 37def70ef36929a490fabd36a7b31c31c2bbbe66
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8bed6ab81a11bda3f3d3a4e4d9239f901d899a6d&tochange=37def70ef36929a490fabd36a7b31c31c2bbbe66

Setting browser.urlbar.richSuggestions.featureGate to false immediately resolves the issue on Linux, and after a restart on Windows.

mozregression --pref browser.urlbar.richSuggestions.featureGate:true --bad 116 returned

Last good revision: 27a022ccd011a0d52e64fe813bbc54d17c869597
First bad revision: cdcf9d894d0573d249e80dbf465226cd134caa68
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27a022ccd011a0d52e64fe813bbc54d17c869597&tochange=cdcf9d894d0573d249e80dbf465226cd134caa68

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

This bug might be related to Bug 1839921.

Comment 3

[Petruta Horea [:phorea]]

Attachment: 117nightly

Reproduced in latest 117.0a1 Nightly under Win 10 & Ubuntu 22.

Comment 4

[Marco Bonardo [:mak]]

Also the pinned site indicators for Top Sites are showing the same problem.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839921

:daleharvey, since you are the author of the regressor, bug 1839921, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1843601 - Properly align type icon with rich suggestions enabled. r=daleharvey

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a29cbf8b7e34
Properly align type icon with rich suggestions enabled. r=daleharvey

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a29cbf8b7e34

Comment 9

[Petruta Horea [:phorea]]

Verified as fixed on Nightly 118.0a1 2023-08-18 under Win 10 64-bit, Ubuntu 22.04 and Mac OSX 12.