1843610 - Add telemetry for deferred deep link test

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, enhancement)

Description

[Roger Yang [:royang]]

Add telemetry to measure if user receives our test deferred deep link from Google App Campaigns. This telemetry will also measure the timing of when we receive the test deferred deep link.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (#2851)

Comment 2

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/186a4b76e5be73466397c0c2fcaca4eaaa2a88da
[main] Bug 1843610 - Add telemetry for deferred deep link test

Comment 3

[Roger Yang [:royang]]

To test on nightly, enter this in command line " adb shell am start -d fenix-dev://test_deferred_deep_link". This should trigger the telemetry.

Comment 4

[Andrei Mocirean]

Hello,
We would need extra steps to reproduce, and what's the expected result. Currently, the app is opened but there is no behaviour on the telemetry itself, the pings are not sent to the glean dashboard.
Are we looking after a "deferred_deeplink_time" metric?
A command that would also send the metric to glean dashboard would be very helpful.
Thank you

Comment 5

[Roger Yang [:royang]]

Sorry :amocirean, I should have been more clear. On Nightly the command should be "adb shell am start -d fenix-nightly://test_deferred_deep_link". Depends on which branch you're testing on, you'll have to use the deep link scheme of that version.

I don't think this needs to be QA'd since the code added is to test deferred deep link on Nightly. I'll remove the QA-verify+ tag. Thanks

Comment 6

[Roger Yang [:royang]]

Comment on attachment 9343945 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (#2851)

Beta/Release Uplift Approval Request

• User impact if declined: Can't confirm if deferred deep link works and will not have the timing needed for attribution based onboarding.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This adds a new deep link that when it is triggered will send a telemetry. No behaviour changes and the user will not see anything on UX.
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 7

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (backport #2851) (#2929)

Comment 8

[Dianna Smith [:diannaS]]

The backport has conflicts that need to be resolved

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9344891 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (backport #2851) (#2929)

switching flag

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (backport #2851) (#2933)

Comment 11

[Roger Yang [:royang]]

Resolved conflict manually. Thanks

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9344943 [details] [review]
[mozilla-mobile/firefox-android] Bug 1843610 - Add telemetry for deferred deep link test (backport #2851) (#2933)

Approved for Mobile 116.0b8

Comment 13

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/144963c7e6b77a189df97682ae2332601fa00636
[releases_v116] Bug 1843610 - Add telemetry for deferred deep link test (#2933)

Comment 14

[Lorand Janos]

Since this didn't need manual QA verification for Nightly either, I'll remove the qe-verify+ flag.

Comment 15

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Revert "Bug 1843610 - Add telemetry for deferred deep link test" (#3754)

Comment 16

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/0895b9a80e889c4f59134dbf6fd4f57ef872a57e
[main] Revert "Bug 1843610 - Add telemetry for deferred deep link test"

Comment 17

[Ryan VanderMeulen [:RyanVM]]

This revert probably should have landed in a different bug to avoid confusion around the flags.

Comment 18

[Roger Yang [:royang]]

Yes, agreed. Didn't think about the confusion this causes. We'll just let the revert ride the train in v120. I don't think there's a need to uplift.