1843668 - Hide wasm final types behind a flag by default

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Comment 1

[Julien Pages [:jpages]]

The patch with wasm final types has landed a few days ago.
Some external tools are broken because of all types (with wasm-gc) are now final by default.

This feature could be behind a flag for now to not break existing tools and give them more time to do the transition.

Comment 2

[Julien Pages [:jpages]]

Attachment: Bug 1843668 - Add an option and pref to enable wasm-gc final types. r=rhunt

This commit puts final types (part of the wasm-gc spec) behind a flag
for a smoother transition with this feature. Final types are now disabled
by default.

javascript.options.wasm_final_types is the browser pref.
--wasm-final-types is the js shell option.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f197a2440b3
Add an option and pref to enable wasm-gc final types. r=rhunt

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3f197a2440b3

Comment 5

[Ryan Hunt [:rhunt]]

Comment on attachment 9346157 [details]
Bug 1843668 - Add an option and pref to enable wasm-gc final types. r=rhunt

Beta/Release Uplift Approval Request

• User impact if declined: The Kotlin programming is experimenting with using the wasm-gc feature, which is available behind a pref. We recently made a breaking change to the proposal that causes Kotlin apps to no longer work with wasm-gc. We decided it'd be better to make the breaking change in the final release of the feature (sometime this fall) to minimize disruption. So we wrote this patch to hide it behind another pref.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch has been tested in Nightly. Patch was manually tested on beta branch. It only affects the Wasm-GC proposal which must be enabled via a pref, so this will only effect users that are experimenting with it (like Kotlin).
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9346157 [details]
Bug 1843668 - Add an option and pref to enable wasm-gc final types. r=rhunt

Approved for 117.0b5

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2af4c52cc502