1843755 - 'Recently Closed Tabs' is missing 'Reopen all Tabs' entry

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[tobias]

str:

1. open a second tab
2. close it again
3. press alt and go to history-> recently closed tabs. notice 'reopen all tabs' is missing below the seperator
4. go to hamburger menu -> history -> recently closed tabs. notice 'reopen all tabs' is missing at the very bottom

error in browser console after step 3:

Key key_undoCloseTab of menuitem Wikipedia could not be found menu.js:295:21
    accelText chrome://global/content/elements/menu.js:295
    _computeAccelTextFromKeyIfNeeded chrome://global/content/elements/menu.js:300
    render chrome://global/content/elements/menu.js:327
    connectedCallback chrome://global/content/elements/menu.js:343
    populateUndoSubmenu chrome://browser/content/browser-places.js:644
    onpopupshowing chrome://browser/content/browser.xhtml:1

i've done a bisection and landed on this pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=14f6c2036ea433f941cbf87dd29e7ef5f1add1a7&tochange=aa4368bfb81a757e2ae5488aca4791a532b566f1 which suggests that this regression was introduced with Bug 1819675.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1819675

Comment 2

[Sam Foster [:sfoster] (he/him)]

Thanks, I'll take a look.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1843755 - Fix the missing 'Reopen all tabs' button and add a test for it. r?sclements!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3992d1425898
Fix the missing 'Reopen all tabs' button and add a test for it. r=sclements,sessionstore-reviewers

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3992d1425898

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-07-17 Nightly build on Windows 10.
Verified as fixed on Firefox 117.0b3(build ID: 20230803180221) and Nightly 118.0a1(build ID: 20230803214045) on Windows 10, macOS 12, Ubuntu 22.