1843829 - gfx/harfbuzz/src/hb-algs.hh:319:29: error: possible misuse of comma operator here [-Werror,-Wcomma]

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[:gerard-majax]

Likely triggered by sccache-dist as bug 1780461 and bug 1779200

Comment 1

[:gerard-majax]

Attachment: Bug 1843829 - Silence new Wcomma error after HarfBuzz update to 8.0.0 r?jfkthame!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1842425

:jfkthame, since you are the author of the regressor, bug 1842425, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Jonathan Kew [:jfkthame]]

Could you file this upstream at https://github.com/harfbuzz/harfbuzz/issues, so that it gets fixed there? Thanks!

Comment 4

[:gerard-majax]

(In reply to Jonathan Kew [:jfkthame] from comment #3)

Could you file this upstream at https://github.com/harfbuzz/harfbuzz/issues, so that it gets fixed there? Thanks!

Of course, but can you give me your opinion on the WIP I have ?

Comment 5

[Jonathan Kew [:jfkthame]]

I'm not really clear why this would fix the warning; at least when -Wcomma was created, it looks like compound assignments were supposed to be allowed on the LHS, so this usage ought to have been accepted as-is. But maybe the heuristics have been updated since the original implementation; I haven't looked further into it.

Anyhow, this looks similar to previous fixes for the same warning, so should be fine AFAICS.

Comment 6

[:gerard-majax]

Not sure if upstream fixed the same way or picked my changes, but they just fixed it :)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a15a30a2c859
Silence new Wcomma error after HarfBuzz update to 8.0.0 r=jfkthame

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a15a30a2c859

Comment 9

[:gerard-majax]

With update to 8.0.1 this has regressed again with the same patch required

Comment 10

[:gerard-majax]

Attachment: Bug 1843829 - Silence new Wcomma error after HarfBuzz update to 8.0.1 r?jfkthame!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06780b0e2840
Silence new Wcomma error after HarfBuzz update to 8.0.1 r=jfkthame

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/06780b0e2840