1843907 - Perma-fails on fenix on firefox-android

Status: VERIFIED FIXED

(Testing :: Raptor, defect, P1)

Description

[Greg Mierzwinski [:sparky]]

Currently all Fenix performance tests are perma-failing because of the following crash - right now this is only on firefox-android, but will spread to mozilla-central soon too:

--------- beginning of crash
07-17 16:50:55.080 18375 18375 E AndroidRuntime: FATAL EXCEPTION: main
07-17 16:50:55.080 18375 18375 E AndroidRuntime: Process: org.mozilla.fenix, PID: 18375
07-17 16:50:55.080 18375 18375 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.HomeActivity}: java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3780)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3956)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2295)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:106)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:246)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8443)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:596)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: Caused by: java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.net.Uri.getQueryParameter(Uri.java:1709)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.net.Uri.getBooleanQueryParameter(Uri.java:1762)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at org.mozilla.fenix.HomeActivity.onCreate(HomeActivity.kt:112)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8183)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.Activity.performCreate(Activity.java:8167)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3753)
07-17 16:50:55.080 18375 18375 E AndroidRuntime: 	... 11 more
07-17 16:50:55.081 18375 18375 E ExceptionHandler: Uncaught exception handled: 
07-17 16:50:55.081 18375 18375 E ExceptionHandler: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.HomeActivity}: java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3780)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3956)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2295)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.os.Handler.dispatchMessage(Handler.java:106)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.os.Looper.loop(Looper.java:246)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.ActivityThread.main(ActivityThread.java:8443)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at java.lang.reflect.Method.invoke(Native Method)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:596)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1130)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: Caused by: java.lang.UnsupportedOperationException: This isn't a hierarchical URI.
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.net.Uri.getQueryParameter(Uri.java:1709)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.net.Uri.getBooleanQueryParameter(Uri.java:1762)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at org.mozilla.fenix.HomeActivity.onCreate(HomeActivity.kt:112)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.Activity.performCreate(Activity.java:8183)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.Activity.performCreate(Activity.java:8167)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3753)
07-17 16:50:55.081 18375 18375 E ExceptionHandler: 	... 11 more
07-17 16:50:55.081 18375 18375 I mozac/CrashReporter: Received crash: UncaughtExceptionCrash(timestamp=1689612655081, throwable=java.lang.RuntimeException: Unable to start activity ComponentInfo{org.mozilla.fenix/org.mozilla.fenix.HomeActivity}: java.lang.UnsupportedOperationException: This isn't a hierarchical URI., breadcrumbs=[], uuid=b71b0286-9358-48c9-aa8f-d9314de7e318)

It started in this push: https://treeherder.mozilla.org/jobs?repo=firefox-android&selectedTaskRun=IQ204lhzS6u83jWpV6jTmQ.0&revision=6a92f5665383f3a7c3727f1f25c45c69fe04983b

If you look in the artifacts, you can find the crash in the logcat one: https://firefoxci.taskcluster-artifacts.net/Hu3SU3H7Sjy_wwcavzUQJg/1/public/test_info/logcat-R58R371JZWL.log

Comment 1

[Greg Mierzwinski [:sparky]]

We've found that it's caused by this patch: https://github.com/mozilla/application-services/pull/5727

:jhugman, can you look into this? Let me know if there's anything you need help with.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox117 (nightly). We have limited time to fix this, the soft freeze is in 9 days. However, the bug still isn't assigned.

:davehunt, could you please find an assignee for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: pr 5733: Bug 1843907 Fixup URI crash for Fenix

Comment 4

[James Hugman [:jhugman] [@jhugman]]

PR merged. Without further intervention, this will appear in the next nightly of Fenix.

Comment 5

[Greg Mierzwinski [:sparky]]

Thanks for the quick fix :jhugman!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Confirmed fixed by https://github.com/mozilla-mobile/firefox-android/commit/deb81b9ad90bee9b5f9c911dfaedeb77d611fd03