1843965 - Do not trace ParseTask::compileStorage_

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

JS::CompilationStorage does not contain GC pointer, and it doesn't need trace.

https://searchfox.org/mozilla-central/rev/7a4c08f2c3a895c9dc064734ada320f920250c1f/js/src/vm/HelperThreadState.h#515-517,533

struct ParseTask : public mozilla::LinkedListElement<ParseTask>,
                   public JS::OffThreadToken,
                   public HelperThreadTask {
...
  JS::CompilationStorage compileStorage_;

https://searchfox.org/mozilla-central/rev/7a4c08f2c3a895c9dc064734ada320f920250c1f/js/src/vm/HelperThreads.cpp#558,563

void ParseTask::trace(JSTracer* trc) {
...
  compileStorage_.trace(trc);

https://searchfox.org/mozilla-central/rev/7a4c08f2c3a895c9dc064734ada320f920250c1f/js/public/experimental/CompileScript.h#104

JS_HAZ_NON_GC_POINTER js::frontend::CompilationInput* input_ = nullptr;

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1843965 - Do not trace ParseTask. r?nbp!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d74693a9777
Do not trace ParseTask. r=nbp

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1d74693a9777