1843973 - Do not root CompilationInput in DelazifyCanonicalScriptedFunctionImpl

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

In FrontendContext variant of delazification, CompilationInput doesn't contain any GC pointer and it doesn't need tracing.

https://searchfox.org/mozilla-central/rev/7a4c08f2c3a895c9dc064734ada320f920250c1f/js/src/frontend/BytecodeCompiler.cpp#1392

Rooted<CompilationInput> input(cx, CompilationInput(options));

we could do in the same way as CompilationStorage, but without allocating it on heap.

https://searchfox.org/mozilla-central/rev/7a4c08f2c3a895c9dc064734ada320f920250c1f/js/public/experimental/CompileScript.h#98,104

struct CompilationStorage {
...
  JS_HAZ_NON_GC_POINTER js::frontend::CompilationInput* input_ = nullptr;

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1843973 - Do not root CompilationInput in DelazifyCanonicalScriptedFunctionImpl. r?nbp!

Depends on D183831

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62bbf798e78d
Do not root CompilationInput in DelazifyCanonicalScriptedFunctionImpl. r=nbp

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/62bbf798e78d