1844036 - The PDF file is saved with blank pages and missing contents when adding images with different file types

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Dana Lucaci, Desktop QA]

Attachment: 2023-07-18_13h03_30.mp4

Found in

• Nightly 117.0a1 (2023-07-17)

Affected versions

• Nightly 117.0a1

Affected platforms

• All

Steps to reproduce

1. Open a PDF file in Firefox.
2. Add Several images types to the PDF file.
3. Click on the Print preview button.
4. Print the PDF file by pressing the "Save" button.

Expected result

The PDF file is correctly saved with its content unchanged and with its images/content successfully displayed.

Actual result

The PDF file is saved with blank pages and missing contents.

Regression range
N/A

Notes
Sometimes the PDF files are saved with only the images missing, other times the whole pages are saved blank.

Comment 1

[Calixte Denizet (:calixte)]

An easy str:

• open a pdf with at least two pages
• add an image on the first page
• copy and paste the image on the second page
• add an other image (different of the first one) on the second page
• print

When page 2 is printed we look for the annotation containing the bitmap originally on page 1:
https://github.com/mozilla/pdf.js/blob/43fc78899fea71cdadb4883aeeec51b849c29b3d/src/core/document.js#L452-L465
but we don't generate the images created for annotations on page 2.

Comment 2

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Don't forget to generate non-missing images when printing (bug 1844036) (#16706)

Comment 3

[Rolland Eduard Rus]

Reproduced the issue on Nightly 117.0a1 (2023-07-18) following the STR, on Windows 11, Ubuntu 22 and macOS 13.
Verified it on Nightly 118.0a1 (2023-08-21) and 117.0 (with pref manually turned on, pref is off by default) builds on macOS 13, Windows 11 and Ubuntu 22, and can confirm that the issue is fixed.