1844053 - Selector highlighter icon can't be focused Tab and is missing role

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

On-screen “Highlight all elements matching this selector” control is not focused with logical keyboard navigation (with Tab), it can only be accessed when a screen reader is running, but the role is missing

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:jdescottes, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844053 - [devtools] Make selector highlighter icon keyboard accessible. r=#devtools-reviewers.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d1230bf1bc5
[devtools] Make selector highlighter icon keyboard accessible. r=devtools-reviewers,ochameau.

Comment 4

[Cristina Horotan [:chorotan]]

Backed out changeset 1d1230bf1bc5 (bug 1844053) for causing dt failures at browser_rules_edit-selector-commit.js and browser_inspector_textbox-menu.js

Backout: https://hg.mozilla.org/integration/autoland/rev/24ae69ef751e07e499c5cb77e9542c787e1b82d5

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1d1230bf1bc54c131f96174fae9467e424e3f9d7

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=431255964&repo=autoland&lineNumber=21515
https://treeherder.mozilla.org/logviewer?job_id=431256038&repo=autoland&lineNumber=19111

Comment 5

[Phabricator Automation]

Comment on attachment 9356347 [details]
Bug 1844053 - [devtools] Make selector highlighter icon keyboard accessible. r=#devtools-reviewers.

Revision D189916 was moved to bug 1844062. Setting attachment 9356347 [details] to obsolete.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1844053 - [devtools] Make selector highlighter icon keyboard accessible. r=#devtools-reviewers.

Depends on D189916

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

this disrupt the current behavior of tabbing in the rule view, which eventually is something we do want, but we need to change some tests along the way

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29dae6b6f95
[devtools] Make selector highlighter icon keyboard accessible. r=devtools-reviewers,ochameau.

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d29dae6b6f95