Closed Bug 1844061 Opened 7 months ago Closed 3 months ago

toggle buttons in top toolbar (:hov, .cls, print and dark/light mode simulation) do not communicate their active/selected state

Categories

(DevTools :: Inspector: Rules, defect, P3)

defect

Tracking

(Accessibility Severity:s3, firefox122 fixed)

RESOLVED FIXED
122 Branch
Accessibility Severity s3
Tracking Status
firefox122 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(2 files)

No description provided.
Summary: :hov button does not communicate its active/selected state → toggle buttons in top toolbar (:hov, .cls, print and dark/light mode simulation) do not communicate their active/selected state
Accessibility Severity: --- → s3
Priority: -- → P3

This handles the aria-pressed attribute on toggle pseudo class,
toggle class panel, light, dark and print mode simulation buttons
in the Rules view toolbar.
We remove the checked class that we were using to style the
button when they are pressed as we can use an attribute selector
with aria-pressed.
For the pseudo-class toggle and the class panel toggle, we also
add aria-controls attribute as they both control the display
of another element.
Tests are updated accordingly.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Attachment #9365821 - Attachment description: Bug 1844061 - [devtools] Set aria attributes on Rules view toolbar buttons. r=#devtools-reviewers, ##accessibility-frontend-reviewers. → Bug 1844061 - [devtools] Set aria attributes on Rules view toolbar buttons. r=#devtools-reviewers, #accessibility-frontend-reviewers.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8cfd3aef7f2
[devtools] Set aria attributes on Rules view toolbar buttons. r=devtools-reviewers,accessibility-frontend-reviewers,ochameau,morgan.
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.