Closed Bug 1844206 Opened 3 years ago Closed 3 years ago

Rework IsConfigSupported for h265

Categories

(Core :: Audio/Video: Web Codecs, task, P1)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

No description provided.
Summary: Use more explicit error message when rejecting IsConfigSupported → Rework IsConfigSupported
Summary: Rework IsConfigSupported → Rework IsConfigSupported for h265

This patch adds a new function to parse H265 info.

Most of the code is borrowed from chromium [1] and checked with the H265
spec [2].

[1] https://source.chromium.org/chromium/chromium/src/+/main:media/base/video_codecs.cc;l=734;drc=caae8720b6a98875e237ab2f9be2a95d34f93caf
[2] https://www.itu.int/rec/T-REC-H.265

Depends on D183927

This patches allows VideoDecoder to validate a H265 string. However,
since we don't support H265 in our decode pipeline yet, decoding the
h265 video will yeild an error.

The difference with the patch is that the IsConfigSupported now resolves
the promise with an codec-unsupported message instead of throwing a
TypeError saying this codec is invalid.

Depends on D184052

Pushed by cchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51d73caa4afd Reject IsConfigSupported with explicit error message r=padenot https://hg.mozilla.org/integration/autoland/rev/698f13a71041 Add error logs in Configure & IsConfigSupported r=padenot https://hg.mozilla.org/integration/autoland/rev/c735fa0ce643 Add error logs in VideoDecoderConfigInternal::Create r=padenot https://hg.mozilla.org/integration/autoland/rev/6ff04682013b Add utils parsing H265 codec string r=media-playback-reviewers,alwu https://hg.mozilla.org/integration/autoland/rev/e25889ce01c8 Validate H265 codec string in VideoDecoder r=padenot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: