1844285 - Fails to build on Solaris OS due to missing sys/ioccom.h headers

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1840272#c23

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Folks, can you answer this question please?

https://phabricator.services.mozilla.com/D182440#inline-1011605

That being said, are there other OSes than solaris that have this header? And do some versions of solaris come without it? Because if it's solaris only and on any version of solaris, you might as well #ifdef sun... but a quick google search says it's also on BSD. Is the include necessary on BSD too? (because this will add the include there too)

Comment 2

[Landry Breuil (:gaston)]

per http://bxr.su/search?q=&defs=&refs=&path=ioccom.h it seems the header exists on all BSDs. It's included in various places, which explains why it wasn't needed to include it explicitely to fix bug #1840272.

Comment 3

[Petr Sumbera]

I have checked Solaris 10u11 and it's there. It also contains prettly old copyrights:
Copyright (c) 1984, 1986, 1987, 1988, 1989 AT&T

But for Firefox only Solaris 11.4 is relevant these days.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Landry Breuil (:gaston) from comment #2)

per http://bxr.su/search?q=&defs=&refs=&path=ioccom.h it seems the header exists on all BSDs. It's included in various places, which explains why it wasn't needed to include it explicitely to fix bug #1840272.

So it looks like we should include it if it's present.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1844285 [Solaris] Include sys/ioccom.h if it's available for dmabuf operations r?glandium

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/991811626f3c
[Solaris] Include sys/ioccom.h if it's available for dmabuf operations r=glandium

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/991811626f3c