Closed Bug 1844300 Opened 7 months ago Closed 3 months ago

Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: zsun)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In order to enable more test for the popover feature.

To get the list of folders for candidate tests using the popover feature from bash:

git grep -w popover testing/web-platform/tests/ | cut -d: -f1 | sort - | uniq - | xargs dirname | uniq -

Result:

testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/fullscreen/api
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

For instance, https://searchfox.org/mozilla-central/rev/907db2c22743f1b24496198b10a3dca4085cfb08/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-002.html hasn't the pref set to true.

Summary: Check for WPTs the pref `dom.element.popover.enabled` should be set to `true` → Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`
Assignee: nobody → zsun
Status: NEW → ASSIGNED

(In reply to Mirko Brodesser (:mbrodesser-Igalia) from comment #0)

In order to enable more test for the popover feature.

To get the list of folders for candidate tests using the popover feature from bash:

git grep -w popover testing/web-platform/tests/ | cut -d: -f1 | sort - | uniq - | xargs dirname | uniq -

Result:

testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/fullscreen/api
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

For instance, https://searchfox.org/mozilla-central/rev/907db2c22743f1b24496198b10a3dca4085cfb08/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-002.html hasn't the pref set to true.

Updates with -
testing/web-platform/tests/close-watcher
testing/web-platform/tests/close-watcher/resources
testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectlist-element
testing/web-platform/tests/html/semantics/invokers
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

Otherwise some exisiting tests will fail. We can try to remove this flag once anchor
positioning is in.

Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/87e2f5b16af1
Set WPT pref `dom.element.popover.enabled` to false for css-position tests. r=emilio
Attachment #9364141 - Attachment description: Bug 1844300 - Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`. r=emilio,mbrodesser-Igalia → Bug 1844300 - Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`. r=emilio
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/6a6e9ae07a68
Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`.  r=emilio
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/f2558d4ebe41
Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`.  r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
Attachment #9364141 - Attachment description: Bug 1844300 - Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`. r=emilio → Bug 1844300 - Set pref `dom.element.popover.enabled` to `true` for related wpt tests. r=emilio
Pushed by zsun@igalia.com:
https://hg.mozilla.org/integration/autoland/rev/a19fb41680f5
Set pref `dom.element.popover.enabled` to `true` for related wpt tests.  r=emilio
Flags: needinfo?(zsun)
You need to log in before you can comment on or make changes to this bug.