1844300 - Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

In order to enable more test for the popover feature.

To get the list of folders for candidate tests using the popover feature from bash:

git grep -w popover testing/web-platform/tests/ | cut -d: -f1 | sort - | uniq - | xargs dirname | uniq -

Result:

testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/fullscreen/api
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

For instance, https://searchfox.org/mozilla-central/rev/907db2c22743f1b24496198b10a3dca4085cfb08/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-002.html hasn't the pref set to true.

Comment 1

[zsun]

Attachment: Bug 1844300 - Set pref `dom.element.popover.enabled` to `true` for related wpt tests. r=emilio

Comment 2

[zsun]

(In reply to Mirko Brodesser (:mbrodesser-Igalia) from comment #0)

In order to enable more test for the popover feature.

To get the list of folders for candidate tests using the popover feature from bash:

git grep -w popover testing/web-platform/tests/ | cut -d: -f1 | sort - | uniq - | xargs dirname | uniq -

Result:

testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/fullscreen/api
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectmenu-element
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

For instance, https://searchfox.org/mozilla-central/rev/907db2c22743f1b24496198b10a3dca4085cfb08/testing/web-platform/tests/css/css-contain/content-visibility/content-visibility-with-popover-top-layer-002.html hasn't the pref set to true.

Updates with -
testing/web-platform/tests/close-watcher
testing/web-platform/tests/close-watcher/resources
testing/web-platform/tests/css/css-contain/content-visibility
testing/web-platform/tests/css/css-position/overlay
testing/web-platform/tests/css/css-toggle
testing/web-platform/tests/custom-elements/reactions
testing/web-platform/tests/html/dom
testing/web-platform/tests/html/semantics/forms/the-selectlist-element
testing/web-platform/tests/html/semantics/invokers
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/html/semantics/popovers/resources
testing/web-platform/tests/html/semantics/popovers
testing/web-platform/tests/interfaces
testing/web-platform/tests/tools/runner/css

Comment 3

[zsun]

Attachment: Bug 1844300 - Set WPT pref `dom.element.popover.enabled` to false for css-position tests. r=emilio,mbrodesser-Igalia

Otherwise some exisiting tests will fail. We can try to remove this flag once anchor
positioning is in.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87e2f5b16af1
Set WPT pref `dom.element.popover.enabled` to false for css-position tests. r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a6e9ae07a68
Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`.  r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failure on popover-closewatcher.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/57d38d110f72e27bab2456e5b81b5b080c266301
Log link: https://treeherder.mozilla.org/logviewer?job_id=436927974&repo=autoland&lineNumber=2272

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2558d4ebe41
Check for which WPTs the pref `dom.element.popover.enabled` should be set to `true`.  r=emilio

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failure on popover-closewatcher.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/2ebfbd12670fc8f9eef1b2de7e3426d8dc9ae0b1
Log link: https://treeherder.mozilla.org/logviewer?job_id=436966492&repo=autoland&lineNumber=2271

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/87e2f5b16af1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a19fb41680f5
Set pref `dom.element.popover.enabled` to `true` for related wpt tests.  r=emilio

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a19fb41680f5