1844559 - Perma SM builds /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13 Error: Assertion failed: got false, expected true: function-references must be enabled only on nightly when Gecko 117 merges to Beta on 2023-07-31

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Iulian Moraru]

[Tracking Requested - why for this release]:

• Central-as-beta simulation.
• How to run these simulations.

Failure log:

[task 2023-07-20T11:43:36.761Z] TEST-PASS | js/src/jit-test/tests/wasm/features.js | Success (code 0, args "--wasm-exceptions") [0.1 s]
[task 2023-07-20T11:43:36.837Z] [COV] no shared memory bitmap available, skipping
[task 2023-07-20T11:43:36.838Z] [COV] edge counters initialized. Shared memory: (null) with 304671 edges
[task 2023-07-20T11:43:36.838Z] executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.839Z] executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.839Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13 Error: Assertion failed: got false, expected true: function-references must be enabled only on nightly
[task 2023-07-20T11:43:36.839Z] Stack:
[task 2023-07-20T11:43:36.840Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13
[task 2023-07-20T11:43:36.840Z] Exit code: 3
[task 2023-07-20T11:43:36.841Z] FAIL - wasm/features.js
[task 2023-07-20T11:43:36.841Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-function-references") [0.1 s]
[task 2023-07-20T11:43:36.841Z] INFO exit-status     : 3
[task 2023-07-20T11:43:36.842Z] INFO timed-out       : False
[task 2023-07-20T11:43:36.842Z] INFO stdout          > [COV] no shared memory bitmap available, skipping
[task 2023-07-20T11:43:36.842Z] INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 304671 edges
[task 2023-07-20T11:43:36.843Z] INFO stderr         2> executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.843Z] INFO stderr         2> executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.844Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13 Error: Assertion failed: got false, expected true: function-references must be enabled only on nightly
[task 2023-07-20T11:43:36.844Z] INFO stderr         2> Stack:
[task 2023-07-20T11:43:36.844Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13
[task 2023-07-20T11:43:36.845Z] TEST-PASS | js/src/jit-test/tests/wasm/fac.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.4 s]
[task 2023-07-20T11:43:36.845Z] TEST-PASS | js/src/jit-test/tests/wasm/features.js | Success (code 0, args "--test-wasm-await-tier2") [0.1 s]
[task 2023-07-20T11:43:36.857Z] [COV] no shared memory bitmap available, skipping
[task 2023-07-20T11:43:36.858Z] [COV] edge counters initialized. Shared memory: (null) with 304671 edges
[task 2023-07-20T11:43:36.858Z] executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.858Z] executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.859Z] /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13 Error: Assertion failed: got false, expected true: function-references must be enabled only on nightly
[task 2023-07-20T11:43:36.859Z] Stack:
[task 2023-07-20T11:43:36.860Z]   @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13
[task 2023-07-20T11:43:36.860Z] Exit code: 3
[task 2023-07-20T11:43:36.860Z] FAIL - wasm/features.js
[task 2023-07-20T11:43:36.861Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/features.js | executionHash is 0x1 with 0 inputs (code 3, args "--wasm-gc") [0.2 s]
[task 2023-07-20T11:43:36.861Z] INFO exit-status     : 3
[task 2023-07-20T11:43:36.861Z] INFO timed-out       : False
[task 2023-07-20T11:43:36.862Z] INFO stdout          > [COV] no shared memory bitmap available, skipping
[task 2023-07-20T11:43:36.862Z] INFO stdout          > [COV] edge counters initialized. Shared memory: (null) with 304671 edges
[task 2023-07-20T11:43:36.863Z] INFO stderr         2> executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.863Z] INFO stderr         2> executionHash is 0x1 with 0 inputs
[task 2023-07-20T11:43:36.863Z] INFO stderr         2> /builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13 Error: Assertion failed: got false, expected true: function-references must be enabled only on nightly
[task 2023-07-20T11:43:36.864Z] INFO stderr         2> Stack:
[task 2023-07-20T11:43:36.864Z] INFO stderr         2> @/builds/worker/checkouts/gecko/js/src/jit-test/tests/wasm/features.js:41:13
[task 2023-07-20T11:43:36.864Z] TEST-PASS | js/src/jit-test/tests/wasm/features.js | Success (code 0, args "--wasm-compiler=baseline") [0.1 s]

Comment 1

[Iulian Moraru]

Hi Ryan! Can you please take a look at this?
Thank you!

Comment 2

[Yury Delendik (:yury)]

The bug 1832378 changed behavior:

This commit also lets wasm-gc/fr start building in beta/release. They
will remain off by default though (behind a pref).

The tests are somewhat invalid anymore since it is forcing function-references and gc flags on via directives. It needs to be changed.

Comment 3

[Yury Delendik (:yury)]

Attachment: Bug 1844559 - Don't force experimental wasm-gc and -fr features.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16d0472582b2
Don't force experimental wasm-gc and -fr features. r=bvisness

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/16d0472582b2

Comment 6

[Serban Stanca [:SerbanS]]

Verified fixed in today’s beta simulation push.