1844600 - Minor differences in card padding

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Stuart Colville [:muffinresearch]]

Attachment: History.png

There's some minor differences between padding on some of the cards in the new version of view.

See the attached screenshots for some examples - the screenshots show the layout relative to the layout guides drawn by the inspector in devtools.

I would probably expect the cards to be aligned with the heading consistently. Which looks to be the case with "Tabs on other devices".

Comment 1

[Stuart Colville [:muffinresearch]]

Attachment: Recent Browsing.png

Comment 2

[Sam Foster [:sfoster] (he/him)]

Lets hold off fixing this until we get UX review on the rest so we don't end up patching this twice.

Comment 3

[Eric Pang [:epang] UX]

Good catch, we should align with the heading consistently. Also, shadows should not be included in alignment. Thanks!

Comment 4

[Stuart Colville [:muffinresearch]]

Attachment: Bug 1844600 - Fix heading and card alignment r?sclements

Comment 5

[Stuart Colville [:muffinresearch]]

Note: this patch also fixes an additional minor issue where a tiny bit of the box-shadow is visible when scrolling (this is only visible in with the light theme and it's very faint).

Since I'm out on PTO next week, if it needs changes please feel free to take it over.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e946943d32b0
Fix heading and card alignment r=sclements,desktop-theme-reviewers,fxview-reviewers,dao

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e946943d32b0