1844640 - Improve error location for mismatched getter/setter private fields.

Status: NEW

(Core :: JavaScript Engine, enhancement, P5)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

The current error message appears like so:

typein:3:15 SyntaxError: getter and setter for private name #x should either be both static or non static:
typein:3:15 get #x() { }
typein:3:15 ...............^

Would it be better to point the arrow at the beginning of the line, like this?

typein:3:15 get #x() { }
typein:3:15 ....^

Posted here

As to the how, I said this:

To your question, we'd want to do it in a followup bug, but how I imagine having to do it would be to go back and grab the token position before the call to propertyOrMethodName and pass that through noteDeclaredPrivateName and use that token position as the error position.