1844750 - The images for 'Jump back in' and 'Recently' saved are not loaded

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, defect, P3)

Description

[twhite]

Attachment: Screenshot_20230721_120633.png

See attachment for example

Comment 1

[Vlad Dreghici [:vdreghici]]

I have looked into this and it seems like the issue was fixed, the thumbnail is shown for both Jump back in and Recently Saved for me. Seems like the patch for Improving performance of tab thumbnail loading in Compose has fixed this.
I have added the qe-verify tag in order to make sure that this bug was fixed and it can be closed.

Comment 2

[Mira Lobontiu (Android QA)]

Attachment: 1844750.jpg

This issue is still reproducible on Fenix Nightly 120.0a1 from 9/27 with Lenovo tablet M10 (Android 10)

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1844750 - Improve fallback for homepage images thumbnails (#4937)

Comment 4

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/0cea2c63469bb33cc5a411533816049519d80870
[main] Bug 1844750 - Improve fallback for homepage images thumbnails

Comment 5

[Vlad Dreghici [:vdreghici]]

Added qa-verify flag. Steps to verify:

1. Access any website (I recommend quickly going through pocket stories)
2. Add said website to bookmarks.
3. Go to homepage
4. Check "Jump back in" and "Recently saved" image thumbnails

Expected: The thumbnails should not have blank images anymore. The fallbacks for the "Jump back in" are a screenshot of the page, if that fails, then a favicon. For "Recently saved" the fallback should be the favicon.

Comment 6

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 123.0a1 from 01/10 with Motorola Moto G9 plus (Android 11) and OnePlus A3000 (Android 6).

Comment 7

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20240110-093348(1).png