Closed Bug 1844795 Opened 2 years ago Closed 2 years ago

[Intermittent] A diamond shaped element is displayed instead of the featureCallout when opening a New Tab via long click on the “+” button and selecting the “No container” option

Categories

(Firefox :: Messaging System, defect, P2)

Desktop
All
defect

Tracking

()

RESOLVED WORKSFORME
Iteration:
122.1 - Nov 20 - Dec 1
Tracking Status
firefox117 --- affected

People

(Reporter: cfat, Assigned: jprickett)

References

(Blocks 1 open bug)

Details

[Affected versions]:

  • Firefox Nightly 117.0a1 - Build ID: 20230721040926

[Affected Platforms]:

  • Windows 10 x64
  • macOS 12.6.1

[Prerequisites]:

  • Set nimbus.debug pref to “true”.
  • Switch to the Stage environment using the Remote Settings Addon (restart the browser to apply the change).
  • Copy and paste this link in order to force enroll in the experiment: about:studies?optin_slug=mcoman-bug-1826588-bugfix-verification&optin_branch=control&optin_collection=nimbus-preview

[Steps to reproduce]:

  1. Open the browser with the profile from the prerequisites.
  2. Long click the “+” (New Tab) toolbar button.
  3. Without letting the mouse button go, move the mouse so that the cursor hovers over the “No container” option.
  4. Let go of the mouse button.
  5. Observe what happens next.

[Expected result]:

  • A New Tab is opened displaying the featureCallout.

[Actual result]:

  • A diamond-shaped element is displayed instead of the featureCallout on the New Tab.

[Notes]:

  • The issue is not reproducible with the following scenarios:
    -> opening the New Tabs by clicking the “+” button;
    -> opening New Container Tabs;
    -> opening New Tabs through shortcut (“Ctrl”+”T”);
  • The element remains displayed when reloading the New Tab.
  • Will test this scenario with Linux OS once I have access to a machine.
  • Here is a video of the issue: link.

Really nice catch!

Assignee: nobody → jprickett
Blocks: fc-surface
Iteration: --- → 117.2 - July 17 - July 28
Priority: -- → P1
Iteration: 117.2 - July 17 - July 28 → 118.1 - July 31 - Aug 11
Iteration: 118.1 - July 31 - Aug 11 → 118.2 - Aug 14 - Aug 25
Priority: P1 → P2
Iteration: 118.2 - Aug 14 - Aug 25 → 119.1 - Aug 28 - Sept 8
Iteration: 119.1 - Aug 28 - Sept 8 → 119.2 - Sept 11 - Sept 22
Iteration: 119.2 - Sept 11 - Sept 22 → 120.1 - Sep 25 - Oct 6
Iteration: 120.1 - Sep 25 - Oct 6 → 120.2 - Oct 9 - Oct 20
Iteration: 120.2 - Oct 9 - Oct 20 → 121.1 - Oct 23 - Nov 3
Iteration: 121.1 - Oct 23 - Nov 3 → 121.2 - Nov 6 - Nov 17
Iteration: 121.2 - Nov 6 - Nov 17 → 122.1 - Nov 20 - Dec 1

In 119 and 120 we landed enhancements to the feature callout that seem to have addressed this issue. Is it possible to have this re-verified? Thank you!

Flags: needinfo?(cfat)

@Jason, I tried to re-test this issue, unfortunately, the original steps from the bug don't trigger the featureCallout anymore. I used mozregression to find the potential reason why the message is no longer shown and I got this pushlog, where Bug 1838295 is related to the feature.

Could you please look over it and let me know what other steps/changes I could make in order to trigger the featureCallout again?

FWIW, I use this stage recipe, maybe we need to change something in the branch configuration?

Flags: needinfo?(cfat) → needinfo?(jprickett)

Looks like we'll need to create a new verification experiment with parent_selector updated for the new anchors: Array<{...}> format.

Thank you @Shane, we managed to update the recipe and we successfully triggered the featureCallout.

  • I verified that the issue is no longer reproducible on several new Firefox profiles, so I think we are safe to close this issue. I will file a new report in case I will encounter it again in the future.

  • Environment:
    Win 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1
    Firefox Nightly 122.0a1, Beta 121.0b1, Release 120 and Release 119.0.1

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(jprickett)
Resolution: --- → WORKSFORME

That's awesome! Thanks Carmen

You need to log in before you can comment on or make changes to this bug.