1844815 - Migration cleanup and tests for rejecting non-ipv4 hostnames ending in numbers

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[edgul]

As per Bug 1723456, we changed the validity of non-ipv4 URLs that have hostnames ending in numbers.

As a followup, which ideally lands along side the above bug, we want to also implement DB cleanup/migration that filters out newly invalid URLs from an old DB. We should also add some tests that verify the migration is working.

We will need migrations and testing for (at least) cookie and permission URLs for which the nsICookieManager and https://searchfox.org/mozilla-central/source/extensions/permissions/test/unit/test_permmanager_migrate_11-12.js may be useful.

Other components, in particular indexeddb, may also require this. I will add this once we know.

Comment 1

[edgul]

Attachment: Bug 1844815 - Added cookie db cleanup for old non-ipv4 urls with hostnames ending in a number. r=valentin,pbz

Comment 2

[edgul]

Attachment: Bug 1844815 - Added permission db removal of invalid url permissions. r=valentin,pbz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d18908756603
Added cookie db cleanup for old non-ipv4 urls with hostnames ending in a number. r=valentin,cookie-reviewers

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d18908756603

Comment 5

[edgul]

Noting that the permissions migration was left out for now, happy to revisit if we can get further clarity on how to proceed.