1844869 - Clean up and make each login-command-button self-contained for about:logins.

Status: RESOLVED FIXED

(Firefox :: about:logins, task, P3)

Comment 1

[Sidharth Sachdev]

Attachment: Bug 1844869 - Clean up and make each login-command-button self-contained for about:logins. r=#credential-management-reviewers!

Comment 2

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ssachdev, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4b8ac1dfda7
Clean up and make each login-command-button self-contained for about:logins. r=credential-management-reviewers,desktop-theme-reviewers,dao,mtigley,Itiel

Comment 4

[Iulian Moraru]

Backed out for causing bc failures on browser_alertDismissedAfterChangingPassword.js.
There are also multiple TV failures that can be seen below in the "Push with failures" link.

• Push with failures

• Failure log for failures on browser_alertDismissedAfterChangingPassword.js

• Failure log for failures on browser_aaa_eventTelemetry_run_first.js

• Backout link

[task 2023-12-07T15:44:44.644Z] 15:44:44     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 60}]
[task 2023-12-07T15:44:44.644Z] 15:44:44     INFO - load@resource://gre/modules/XULStore.sys.mjs:60:15
[task 2023-12-07T15:44:44.645Z] 15:44:44     INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-12-07T15:44:44.645Z] 15:44:44     INFO - 
[task 2023-12-07T15:44:44.646Z] 15:44:44     INFO - Console message: [JavaScript Error: "InvalidStateError: [fluent] Missing message in locale en-US: create-new-login-button"]
[task 2023-12-07T15:44:44.646Z] 15:44:44     INFO - Buffered messages finished
[task 2023-12-07T15:44:44.649Z] 15:44:44     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_alertDismissedAfterChangingPassword.js | [JavaScript Error: "InvalidStateError: [fluent] Missing message in locale en-US: create-new-login-button"] - false == true - {"filename":"chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js","name":"onConsoleMessage","sourceId":603,"lineNumber":156,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"resource://testing-common/SpecialPowersChild.sys.mjs","name":"observe/<","sourceId":557,"lineNumber":106,"columnNumber":21,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"observe/<@resource://testing-common/SpecialPowersChild.sys.mjs:106:21\n","nativeSavedFrame":{}},"formattedStack":"onConsoleMessage@chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:156:12\nobserve/<@resource://testing-common/SpecialPowersChild.sys.mjs:106:21\n","nativeSavedFrame":{}}
[task 2023-12-07T15:44:44.649Z] 15:44:44     INFO - Stack trace:
[task 2023-12-07T15:44:44.649Z] 15:44:44     INFO - chrome://mochitests/content/browser/browser/components/aboutlogins/tests/browser/head.js:onConsoleMessage:156
[task 2023-12-07T15:44:44.649Z] 15:44:44     INFO - resource://testing-common/SpecialPowersChild.sys.mjs:observe/<:106
[task 2023-12-07T15:44:44.650Z] 15:44:44     INFO - Leaving setup bound 
[task 2023-12-07T15:44:44.650Z] 15:44:44     INFO - Entering test bound test_added_login_shows_breach_warning
[task 2023-12-07T15:44:44.678Z] 15:44:44     INFO - GECKO(1559) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpx21nr27v.mozrunner/runtests_leaks_tab_pid1832.log
[task 2023-12-07T15:44:44.731Z] 15:44:44     INFO - GECKO(1559) | [Child 1832, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:657
[task 2023-12-07T15:44:44.744Z] 15:44:44     INFO - GECKO(1559) | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
[task 2023-12-07T15:44:44.744Z] 15:44:44     INFO - GECKO(1559) | [Child 1832, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:402
[task 2023-12-07T15:44:44.806Z] 15:44:44     INFO - GECKO(1559) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 60: Error: Can't find profile directory.
[task 2023-12-07T15:44:44.806Z] 15:44:44     INFO - GECKO(1559) | [Child 1795, Main Thread] WARNING: '!mLocalStore', file /builds/worker/checkouts/gecko/dom/xul/XULPersist.cpp:146
[task 2023-12-07T15:44:44.811Z] 15:44:44     INFO - GECKO(1559) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 60: Error: Can't find profile directory.
[task 2023-12-07T15:44:44.812Z] 15:44:44     INFO - GECKO(1559) | [Child 1795, Main Thread] WARNING: '!mLocalStore', file /builds/worker/checkouts/gecko/dom/xul/XULPersist.cpp:146
[task 2023-12-07T15:44:44.817Z] 15:44:44     INFO - GECKO(1559) | JavaScript error: resource://gre/modules/XULStore.sys.mjs, line 60: Error: Can't find profile directory.
[task 2023-12-07T15:44:44.818Z] 15:44:44     INFO - GECKO(1559) | [Child 1795, Main Thread] WARNING: '!mLocalStore', file /builds/worker/checkouts/gecko/dom/xul/XULPersist.cpp:146
[task 2023-12-07T15:44:44.821Z] 15:44:44     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 60}]
[task 2023-12-07T15:44:44.821Z] 15:44:44     INFO - load@resource://gre/modules/XULStore.sys.mjs:60:15
[task 2023-12-07T15:44:44.821Z] 15:44:44     INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-12-07T15:44:44.821Z] 15:44:44     INFO - 
[task 2023-12-07T15:44:44.823Z] 15:44:44     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 60}]
[task 2023-12-07T15:44:44.823Z] 15:44:44     INFO - load@resource://gre/modules/XULStore.sys.mjs:60:15
[task 2023-12-07T15:44:44.823Z] 15:44:44     INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-12-07T15:44:44.823Z] 15:44:44     INFO - 
[task 2023-12-07T15:44:44.826Z] 15:44:44     INFO - Console message: [JavaScript Error: "Error: Can't find profile directory." {file: "resource://gre/modules/XULStore.sys.mjs" line: 60}]
[task 2023-12-07T15:44:44.826Z] 15:44:44     INFO - load@resource://gre/modules/XULStore.sys.mjs:60:15
[task 2023-12-07T15:44:44.826Z] 15:44:44     INFO - XULStore@resource://gre/modules/XULStore.sys.mjs:17:10
[task 2023-12-07T15:44:44.826Z] 15:44:44     INFO - 
[task 2023-12-07T15:44:44.895Z] 15:44:44     INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_alertDismissedAfterChangingPassword.js | regular login should not be marked breached or vulnerable: undefined - true == true - 

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6131d8fa7875
Clean up and make each login-command-button self-contained for about:logins. r=credential-management-reviewers,desktop-theme-reviewers,dao,mtigley,Itiel

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6131d8fa7875