1844890 - SearchService's default engine has changed notification bar displays engine id rather than engine name

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Mandy Cheang [:mcheang][she/her]]

The notification bar for default engine change is displaying engine id rather than engine name. I think this is a regression due to refactoring I did sometime ago. See Bug 1786324.

Comment 1

[Mandy Cheang [:mcheang][she/her]]

I've put up a patch so get the engine name before displaying the notification bar. I reference this._engines to retrieve the engine name because this.#addEngineToStore is called beforehand. That means the this._engines map is already populated with engines.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1844890 - Change default engine change notification bar to display engine names rather than engine ids. r=#search-reviewers,Standard8

Comment 3

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: This is a bug that we'd potentially like to include as a ride-along to a RC rebuild or dot release.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bd9e2aadd5e
Change default engine change notification bar to display engine names rather than engine ids. r=Standard8

Comment 5

[Mandy Cheang [:mcheang][she/her]]

Comment on attachment 9345152 [details]
Bug 1844890 - Change default engine change notification bar to display engine names rather than engine ids. r=#search-reviewers,Standard8

Beta/Release Uplift Approval Request

• User impact if declined: When we make an update to the search engines, users might see an infobar displayed if their default engine has changed. Their default engine id is currently displayed rather than the engine name. Displaying the engine id would show a combination of the engine webextension id and the local or it could look even more confusing to the user when it's a non-application engine id. These ids would be a long string of alpha-numeric characters.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

1. Set a engine as default (application provided engine or any open search engine)
2. Remove that engine
3. Restart Firefox
4. Infobar should show up displaying old engine name that's removed, and the new engine name that's been replaced as default. No engine ids should be displayed, only the engine's name.
5. Go through Step 1 to 4 again, but this time test the infobar should show up on 5 minutes idle rather than restart.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change as been manually tested and there are automated tests, and there's no major changes aside from passing in the engine name rather than the engine id to the function.
• String changes made/needed:
• Is Android affected?: Yes

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Same as above. We don't want users to see a notification that is confusing if their default engine has changed.
• User impact if declined: Users will see engine ids, which looks confusing.
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Same as above.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/1bd9e2aadd5e

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 117.0a1(20230726154100) using macOS 14, Ubuntu 22 and Windows 11x64.

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9345152 [details]
Bug 1844890 - Change default engine change notification bar to display engine names rather than engine ids. r=#search-reviewers,Standard8

Approved for 116.0rc2

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mcheang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox116 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Mark Banner (:standard8)]

It has already been requested.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/303282ee6f3a

Comment 12

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 116.0(20230727152340) using macOS 14, Windows 11 and Ubuntu 22.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9345152 [details]
Bug 1844890 - Change default engine change notification bar to display engine names rather than engine ids. r=#search-reviewers,Standard8

Approved for 115.2esr.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/6aced6d6ac98

Comment 15

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on 115.2esr(20230821110938) using macOS 14, Windows11 and Ubuntu 22.