1844956 - Use fluent-rs in browser_misused_characters_in_strings.js

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Tooru Fujisawa [:arai]]

(In reply to Ted Campbell [:tcampbell] from bug 1834205 comment #2)

The FluentSyntax.jsm is only used for a single test case, so maybe we should just try to avoid the dependency on fluent.js entirely now. Maybe it is possible to use https://docs.rs/fluent/latest/fluent/struct.FluentResource.html#method.entries in fluent-rs? It could be somehow exposed on the FluentResource webidl so that most of the plumbing could be reused.

Comment 1

[Tooru Fujisawa [:arai]]

testing https://treeherder.mozilla.org/jobs?repo=try&revision=bce4336fe90dbf2b681de13bd7394f7120c3acbb

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1844956 - Part 1: Use fluent-rs to collect TextElement in browser_misused_characters_in_strings.js. r?emilio!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1844956 - Part 2: Remove FluentSyntax.jsm. r?emilio!

Depends on D184329

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72fb5cfada1a
Part 1: Use fluent-rs to collect TextElement in browser_misused_characters_in_strings.js. r=emilio
https://hg.mozilla.org/integration/autoland/rev/242016d2ee9e
Part 2: Remove FluentSyntax.jsm. r=emilio

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/72fb5cfada1a
https://hg.mozilla.org/mozilla-central/rev/242016d2ee9e