1845104 - Open links in apps set to Never breaks authentication flow of the digiposte website

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Paul Adenot (:padenot)]

Steps to reproduce

This is hard to reproduce because a ditigposte account is needed, but https://moncompte.laposte.fr allows creating one.

This is a service offered by the French post service that can hold important documents, such as (e.g.) Mozilla employee's payslips.

STR:

• Create a digiposte account
• Install the Android app for digiposte
• Install Firefox for Android, make it the default browser
• Set Firefox for Android to never open links in apps
• Attempt to login in the digiposte app: this opens a custom tab with Firefox for Android, you log in

Expected behavior

It goes back to the app, the user is logged in

Actual behavior

It doesn't go back to the app. Attempting to click the button doesn't do anything

This works if the setting is set to ask, or to always allow to open other apps.

The code that breaks is (looking at the digiposte website sources) something like:

document.location.href = "digiposte://something?id=somehash"

and this appears to be blocked. Maybe we should relax this not working when another app has opened the browser, e.g. when a custom tab is being used.

Comment 1

[Titouan Thibaud [:titouan]]

The same issue can be reproduced with an account on the HostelWorld app (and probably other apps that have a similar login flow, I guess)

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1845104 - Open links in the current app from a CustomTab even when OpenInApp settings is set to 'never' (#2990)

Comment 3

[BMO Github Automation]

Authored by Titouan Thibaud
https://github.com/mozilla-mobile/firefox-android/commit/fdf3d6ff6a2377dffad37d44c78e184804c69cff
[main] Bug 1845104 - Open links in the current app from a CustomTab even when OpenInApp settings is set to 'never'

Comment 4

[Lorand Janos]

Verified on the latest Nightly build (117.0a1 from 2023-07-28).
The login process remained in the app, not interfering with Fenix Nightly that was set as default browser with "Open links in apps" set to never.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.