Closed Bug 1845272 Opened 1 year ago Closed 1 year ago

Permafailing Rpk ModuleNotFoundError: No module named 'fluent.runtime'

Categories

(Firefox Build System :: Task Configuration, defect, P1)

defect

Tracking

(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox115 unaffected, firefox116 unaffected, firefox117blocking fixed)

RESOLVED FIXED
117 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox115 --- unaffected
firefox116 --- unaffected
firefox117 blocking fixed

People

(Reporter: intermittent-bug-filer, Assigned: ahochheiden)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(3 files)

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=423794833&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NO5IGz39TJyJGhkEGBOLuQ/runs/2/artifacts/public/logs/live_backing.log


[task 2023-07-25T11:23:24.102Z] 11:23:24     INFO -  Successfully installed babel-2.12.1 fluent.runtime-0.4.0 fluent.syntax-0.19.0 pytz-2023.3 typing-extensions-4.7.1
[task 2023-07-25T11:23:24.319Z] 11:23:24     INFO -  Error running mach:
[task 2023-07-25T11:23:24.319Z] 11:23:24     INFO -      mach --log-no-times repackage deb --arch x86 --templates browser/installer/linux/app/debian --version 117.0a1 --build-number 1 --release-product None --release-type nightly --input /builds/worker/fetches/target.tar.bz2 --output /builds/worker/workspace/outputs/target.deb
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  The error occurred in code that was called by the mach command. This is either
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  a bug in the called code itself or in the way that mach is calling it.
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  You can invoke ``./mach busted`` to check if this issue is already on file. If it
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  isn't, please use ``./mach busted file repackage`` to report it. If ``./mach busted`` is
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  misbehaving, you can also inspect the dependencies of bug 1543241.
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  If filing a bug, please include the full output of mach, including this error
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  message.
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  The details of the failure are as follows:
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -  ModuleNotFoundError: No module named 'redo'
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/mach_commands.py", line 2330, in repackage_deb
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -      from mozbuild.repackaging.deb import repackage_deb
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/repackaging/deb.py", line 22, in <module>
[task 2023-07-25T11:23:24.320Z] 11:23:24     INFO -      from redo import retry
[task 2023-07-25T11:23:24.364Z] 11:23:24     INFO - Return code: 1
[task 2023-07-25T11:23:24.364Z] 11:23:24    ERROR - 1 not in success codes: [0]
[task 2023-07-25T11:23:24.364Z] 11:23:24  WARNING - setting return code to 2
[task 2023-07-25T11:23:24.364Z] 11:23:24    FATAL - Halting on failure while running ['/builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python', 'mach', '--log-no-times', 'repackage', 'deb', '--arch', 'x86', '--templates', 'browser/installer/linux/app/debian', '--version', '117.0a1', '--build-number', '1', '--release-product', 'None', '--release-type', 'nightly', '--input', '/builds/worker/fetches/target.tar.bz2', '--output', '/builds/worker/workspace/outputs/target.deb']
[task 2023-07-25T11:23:24.364Z] 11:23:24    FATAL - Running post_fatal callback...
[task 2023-07-25T11:23:24.364Z] 11:23:24    FATAL - Exiting 2
[task 2023-07-25T11:23:24.364Z] 11:23:24     INFO - [mozharness: 2023-07-25 11:23:24.364892Z] Finished repackage step (failed)
[taskcluster 2023-07-25 11:23:33.852Z] === Task Finished ===
[taskcluster 2023-07-25 11:23:33.864Z] Artifact "public/build" not found at "/builds/worker/artifacts/": (HTTP code 404) no such container - Could not find the file /builds/worker/artifacts/ in container 149e6fe5728a7f431e2d8f92dd02cef0a50485d1874c9fee0209386faa10e278 
[taskcluster 2023-07-25 11:23:33.879Z] Artifact "public/build/target.deb" not found at "/builds/worker/workspace/outputs/target.deb": (HTTP code 404) no such container - Could not find the file /builds/worker/workspace/outputs/target.deb in container 149e6fe5728a7f431e2d8f92dd02cef0a50485d1874c9fee0209386faa10e278 
[taskcluster 2023-07-25 11:23:34.149Z] Unsuccessful task run with exit code: 2 completed in 159.159 seconds

Alex, do you have time to check if Bug 1695312 has anything to do with this?
Thank you!

Flags: needinfo?(ahochheiden)

Yep, that's mine. I will fix.

Assignee: nobody → ahochheiden
Flags: needinfo?(ahochheiden)

This was missed in the dependency rework in D180501.

Pushed by ahochheiden@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ebe18262bdd8 Add missing module 'redo' to `repackage-deb` site r=ahal

I was getting the ModuleNotFoundError: No module named 'redo' error on ./mach wpt as well, and applying this patch didn't seem to fix it, although I may have just applied it wrong.

FWIW, I'm also getting the error running ./mach wpt, after applying the patch, clobbering, rebuilding and running.

I rolled back to before Bug 1695312 and mach wpt worked for me.

This seems to be happening on perftest with startup-<something> on android-hw-a51-11-0-aarch64-shippable opt

failure log for such jobs

Hi Alex! Not sure if this is something that your patch will cover. If you could please take a look at this ^
Thank you!

Flags: needinfo?(ahochheiden)
Summary: Permafailing Rpk ModuleNotFoundError: No module named 'redo' → Permafailing Rpk/perftest startup-<something> ModuleNotFoundError: No module named 'redo'
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Hello Alex! Could you please take another look at this? Now it shifted to No module named 'fluent.runtime', as it can be seen here, and I think it's also caused by your changes.

Thank you!

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 117 Branch → ---
Summary: Permafailing Rpk/perftest startup-<something> ModuleNotFoundError: No module named 'redo' → Permafailing Rpk ModuleNotFoundError: No module named 'fluent.runtime'

(In reply to Greg Tatum [:gregtatum] from comment #5)

I was getting the ModuleNotFoundError: No module named 'redo' error on ./mach wpt as well, and applying this patch didn't seem to fix it, although I may have just applied it wrong.

That should be fixed by https://phabricator.services.mozilla.com/D184519 from Bug 1845365.

(In reply to Iulian Moraru from comment #8)

This seems to be happening on perftest with startup-<something> on android-hw-a51-11-0-aarch64-shippable opt

failure log for such jobs

Hi Alex! Not sure if this is something that your patch will cover. If you could please take a look at this ^
Thank you!

This one's tricky, but I've almost got something that works.

(In reply to Serban Stanca [:SerbanS] from comment #10)

Hello Alex! Could you please take another look at this? Now it shifted to No module named 'fluent.runtime', as it can be seen here, and I think it's also caused by your changes.

Thank you!

Still working on this one, I think my fix for something else in https://phabricator.services.mozilla.com/D184519 may have caused the regression.

Flags: needinfo?(ahochheiden)

Since various dependencies were moved out of the 'mach' site, it itself
is no longer sufficient. Activating the common site solves this
problem, since it has everything that was moved out of the mach site.

(In reply to Alex Hochheiden [:ahochheiden] from comment #11)

(In reply to Serban Stanca [:SerbanS] from comment #10)

Hello Alex! Could you please take another look at this? Now it shifted to No module named 'fluent.runtime', as it can be seen here, and I think it's also caused by your changes.

Thank you!

Still working on this one, I think my fix for something else in https://phabricator.services.mozilla.com/D184519 may have caused the regression.

I actually can't reproduce this on current central. I think this was just a failure before my fix in the other bug landed. I had a different error locally, but that's because I was missing a different fix as well. I think it should be good now. This latest patch should resolve the last issue introduced in bug 1695312.

Duplicate of this bug: 1845649

On the latest merge now we have these failures.
Alex, could you please take a look?

This is blocking the Nightly release graph, which in turn is blocking all Linux nightlies from being updated at the moment. Presumably this is also going to block Beta's release graph next week. We need a fix or backout ASAP given that we're already in the soft freeze for 117.

Severity: S4 → S1
Flags: needinfo?(ahochheiden)
Priority: P5 → P1
Keywords: regression
Regressed by: 1695312

I believe my current patch should fix those. I'm doing a try push right now to confirm and finding somebody to review.

Flags: needinfo?(ahochheiden)
Pushed by ahochheiden@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9682d7c6107b Activate the `common` site virtualenv when calling the `mozperftest/runner.py` script directly (outside of a mach command context) r=ahal
Duplicate of this bug: 1845367
Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Status: RESOLVED → REOPENED
Flags: needinfo?(ahochheiden)
Resolution: FIXED → ---
Target Milestone: 117 Branch → ---

This will make it so that if there was a potential subcommand, but it
was not a real subcommand, the base command's site is still passed
through and activated.

Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/fe8f67887731 Set 'site' early before checking for a `sub_command` `site` r=ahal a=RyanVM
Flags: needinfo?(ahochheiden)

Looks like that did the trick, thanks!

Status: REOPENED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: