1845306 - Test commands e.g. mochitest/geckoview-junit are broken with KeyError: 'test'

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Error running mach:

    mach mochitest dom/push/test

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file mochitest`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: 'test'

  File "C:\Users\sasch\Documents\GitHub\gecko-dev\testing\mochitest\mach_commands.py", line 345, in run_mochitest_general
    format_args = {"level": command_context._mach_context.settings["test"]["level"]}
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "C:\Users\sasch\Documents\GitHub\gecko-dev\python\mach\mach\config.py", line 410, in __getitem__
    return self._sections[k]
           ~~~~~~~~~~~~~~^^^

Clobbering doesn't solve this.

Comment 1

[William Durand [:willdurand]]

FWIW I have the same problem with the geckoview-junit command:

[...]
BUILD SUCCESSFUL in 19s
64 actionable tasks: 3 executed, 61 up-to-date
Error running mach:

    mach geckoview-junit org.mozilla.geckoview.test.WebExtensionTest

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file geckoview-junit`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: 'test'

  File "/Users/william/projects/mozilla/gecko-worktrees/geckoview/testing/mochitest/mach_commands.py", line 548, in run_junit
    format_args = {"level": command_context._mach_context.settings["test"]["level"]}
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/Users/william/projects/mozilla/gecko-worktrees/geckoview/python/mach/mach/config.py", line 410, in __getitem__
    return self._sections[k]
           ~~~~~~~~~~~~~~^^^

Comment 2

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Happening with various mozconfigs with different objdirs, something is definitely broken.

Comment 3

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Alex landed some changes in mach in Bug 1695312, I wonder that's related.

Comment 4

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Reverting bug 1695312 indeed fixes this issue.

Comment 5

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Mach Core' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1695312

Comment 7

[Alex Hochheiden [:ahochheiden] [he/him]]

I'm investigating.

Comment 8

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1845306 - Make some additional commands load all modules so that @SettingsProvider is ran when needed r?ahal

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/057497f52bb2
Make some additional commands load all modules so that @SettingsProvider is ran when needed r=ahal

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/057497f52bb2