Closed Bug 1845500 Opened 3 years ago Closed 3 years ago

Toolbar buttons outside unified toolbar customization area are too high

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Thunderbird 117
defect

Tracking

(thunderbird_esr115? fixed, thunderbird116? affected)

RESOLVED FIXED
117 Branch
Tracking Status
thunderbird_esr115 ? fixed
thunderbird116 ? affected

People

(Reporter: freaktechnik, Assigned: aleca)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 external file)

Attached image screenshot.png —

The app menu and spaces buttons are too high compared to "normal" unified toolbar buttons. See also screenshot (taken with default density).

Assignee: nobody → alessandro
Status: NEW → ASSIGNED
Attachment #9345854 - Attachment description: Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik → Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=micahilbery
Attachment #9345854 - Attachment description: Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=micahilbery → Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik
Target Milestone: --- → 117 Branch
Attachment #9345854 - Attachment description: Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik → Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik,micahilbery

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f8172141481a
Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik,micahilbery

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

With no items on the toolbar, it's impossible to right-click on it and choose Customise, so browser_unifiedToolbarCustomization.js fails. We'll back this out.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/7e191e38e176
Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik,micahilbery

Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
Resolution: --- → FIXED

Comment on attachment 9345854 [details]
Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik,micahilbery

[Approval Request Comment]
Regression caused by (bug #): bug 1843804
User impact if declined: Inconsistent size between unified toolbar buttons and the AppMenu button
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): very low

Attachment #9345854 - Flags: approval-comm-esr115?
Attachment #9345854 - Flags: approval-comm-beta?

Comment on attachment 9345854 [details]
Bug 1845500 - Ensure consistent margin for all the buttons in the unified toolbar. r=freaktechnik,micahilbery

[Triage Comment]
Approved for esr115

Was too late for uplift to 116 beta

Attachment #9345854 - Flags: approval-comm-esr115?
Attachment #9345854 - Flags: approval-comm-esr115+
Attachment #9345854 - Flags: approval-comm-beta?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: