1845576 - Remove `Services.io.offline = true` from xpcshell head.js file or add inline comment to explain why is needed

Status: RESOLVED FIXED

(WebExtensions :: Android, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

While investigating Bug 1844825 (which is tracking re-enabling test_ext_cache_api.js on android builds) we noticed that in the WebExtensions xpcshell tests head.js file we are setting Services.io.offline = true when the xpcshell tests are running on Android builds, that was done as part of Bug 1344616 way before GeckoView, but unfortunately there isn't any comment (in bugzilla or in the patch) that can remind us why that was needed at the time and confirm if it would still be needed at all when the xpcshell tests runs on GeckoView builds.

This bug is tracking either following up to Bug 1844825 short term workaround (setting Services.io.offline back to false in the test_ext_cache_api.js test file itself), with either:

• removing the code setting Services.io.offline to true from the head.js file (if we are unable to hit any test failure by removing it)

• or adding an inline comment that mentions explicitly why would still be needed for Android builds.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1845576 - Remove 'Services.io.offline = true' set on Android from the WebExtensions xpcshell toolkit head.js. r?willdurand!

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try:
https://treeherder.mozilla.org/jobs?repo=try&revision=64be5d052c4a388ade972ada84f098d5aa467a1b

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rpl, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

The patch has been queued to be pushed to autoland.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb3cbd3a06c1
Remove 'Services.io.offline = true' set on Android from the WebExtensions xpcshell toolkit head.js. r=willdurand

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/eb3cbd3a06c1