Closed Bug 1845599 Opened 2 years ago Closed 2 years ago

Add test-262 decorators tests with a feature check

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1845599 - Add feature check for decorators in test262-update.py; r=mgaudet
48 bytes, text/x-phabricator-request
Details | Review
Bug 1845599 - Use InternalWhileEmitter in BytecodeEmitter::emitInitializeStaticFields; r=mgaudet
48 bytes, text/x-phabricator-request
Details | Review
Bug 1845599 - Skip tests for private identifiers in decorators; r=mgaudet
48 bytes, text/x-phabricator-request
Details | Review
Bug 1845599 - Import test262 decorators tests; r=mgaudet
48 bytes, text/x-phabricator-request
Details | Review

We can import the test-262 decorators tests now, with a feature check, to help with testing our implementation.

Assignee: nobody → dminor
Status: NEW → ASSIGNED

Depends on D184731

Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41b4148bd682 Add feature check for decorators in test262-update.py; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/7862249841b2 Use InternalWhileEmitter in BytecodeEmitter::emitInitializeStaticFields; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/3299c8756dce Skip tests for private identifiers in decorators; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/11adb7141a43 Import test262 decorators tests; r=mgaudet

Backed out for jsreftest failures due to getBuildConfiguration

[task 2023-07-28T00:58:37.399Z] 00:58:37     INFO - REFTEST INFO | Reading manifest file:///builds/worker/workspace/build/tests/jsreftest/tests/js/src/tests/jstests.list
[task 2023-07-28T00:58:37.451Z] 00:58:37     INFO - REFTEST INFO | Dumping representation of sandbox which can be used for expectation annotations
[task 2023-07-28T00:58:37.454Z] 00:58:37     INFO - REFTEST INFO |     AddressSanitizer: false
[task 2023-07-28T00:58:37.456Z] 00:58:37     INFO - REFTEST INFO |     Android: false
[task 2023-07-28T00:58:37.456Z] 00:58:37     INFO - REFTEST INFO |     Android13: false
[task 2023-07-28T00:58:37.456Z] 00:58:37     INFO - REFTEST INFO |     appleSilicon: false
[task 2023-07-28T00:58:37.458Z] 00:58:37     INFO - REFTEST INFO |     asyncPan: true
[task 2023-07-28T00:58:37.458Z] 00:58:37     INFO - REFTEST INFO |     azureCairo: false
[task 2023-07-28T00:58:37.458Z] 00:58:37     INFO - REFTEST INFO |     azureSkia: true
[task 2023-07-28T00:58:37.458Z] 00:58:37     INFO - REFTEST INFO |     azureSkiaGL: false
[task 2023-07-28T00:58:37.458Z] 00:58:37     INFO - REFTEST INFO |     browserIsFission: true
[task 2023-07-28T00:58:37.459Z] 00:58:37     INFO - REFTEST INFO |     browserIsRemote: true
[task 2023-07-28T00:58:37.460Z] 00:58:37     INFO - REFTEST INFO |     cocoaWidget: false
[task 2023-07-28T00:58:37.460Z] 00:58:37     INFO - REFTEST INFO |     compareRetainedDisplayLists: false
[task 2023-07-28T00:58:37.461Z] 00:58:37     INFO - REFTEST INFO |     contentSameGfxBackendAsCanvas: true
[task 2023-07-28T00:58:37.462Z] 00:58:37     INFO - REFTEST INFO |     d2d: false
[task 2023-07-28T00:58:37.462Z] 00:58:37     INFO - REFTEST INFO |     d3d11: false
[task 2023-07-28T00:58:37.463Z] 00:58:37     INFO - REFTEST INFO |     d3d9: false
[task 2023-07-28T00:58:37.463Z] 00:58:37     INFO - REFTEST INFO |     dwrite: false
[task 2023-07-28T00:58:37.464Z] 00:58:37     INFO - REFTEST INFO |     embeddedInFirefoxReality: false
[task 2023-07-28T00:58:37.464Z] 00:58:37     INFO - REFTEST INFO |     fission: true
[task 2023-07-28T00:58:37.466Z] 00:58:37     INFO - REFTEST INFO |     geckoview: false
[task 2023-07-28T00:58:37.466Z] 00:58:37     INFO - REFTEST INFO |     gpuProcess: false
[task 2023-07-28T00:58:37.467Z] 00:58:37     INFO - REFTEST INFO |     gpuProcessForceEnabled: false
[task 2023-07-28T00:58:37.468Z] 00:58:37     INFO - REFTEST INFO |     gtkWidget: true
[task 2023-07-28T00:58:37.469Z] 00:58:37     INFO - REFTEST INFO |     http: {"userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0","appName":"Mozilla","appVersion":"5.0","platform":"X11","oscpu":"Linux x86_64","misc":"rv:109.0"}
[task 2023-07-28T00:58:37.470Z] 00:58:37     INFO - REFTEST INFO |     is64Bit: true
[task 2023-07-28T00:58:37.471Z] 00:58:37     INFO - REFTEST INFO |     isCoverageBuild: false
[task 2023-07-28T00:58:37.472Z] 00:58:37     INFO - REFTEST INFO |     isDebugBuild: false
[task 2023-07-28T00:58:37.473Z] 00:58:37     INFO - REFTEST INFO |     jxl: true
[task 2023-07-28T00:58:37.474Z] 00:58:37     INFO - REFTEST INFO |     layersGPUAccelerated: true
[task 2023-07-28T00:58:37.474Z] 00:58:37     INFO - REFTEST INFO |     layersOMTC: true
[task 2023-07-28T00:58:37.475Z] 00:58:37     INFO - REFTEST INFO |     layersOpenGL: false
[task 2023-07-28T00:58:37.476Z] 00:58:37     INFO - REFTEST INFO |     MinGW: false
[task 2023-07-28T00:58:37.477Z] 00:58:37     INFO - REFTEST INFO |     OSX: undefined
[task 2023-07-28T00:58:37.478Z] 00:58:37     INFO - REFTEST INFO |     prefs: {}
[task 2023-07-28T00:58:37.479Z] 00:58:37     INFO - REFTEST INFO |     qtWidget: false
[task 2023-07-28T00:58:37.480Z] 00:58:37     INFO - REFTEST INFO |     release_or_beta: false
[task 2023-07-28T00:58:37.481Z] 00:58:37     INFO - REFTEST INFO |     remoteCanvas: false
[task 2023-07-28T00:58:37.482Z] 00:58:37     INFO - REFTEST INFO |     retainedDisplayList: true
[task 2023-07-28T00:58:37.483Z] 00:58:37     INFO - REFTEST INFO |     retainedDisplayListNew: false
[task 2023-07-28T00:58:37.485Z] 00:58:37     INFO - REFTEST INFO |     serviceWorkerE10s: true
[task 2023-07-28T00:58:37.486Z] 00:58:37     INFO - REFTEST INFO |     skiaContent: true
[task 2023-07-28T00:58:37.486Z] 00:58:37     INFO - REFTEST INFO |     smallScreen: false
[task 2023-07-28T00:58:37.487Z] 00:58:37     INFO - REFTEST INFO |     swgl: false
[task 2023-07-28T00:58:37.487Z] 00:58:37     INFO - REFTEST INFO |     ThreadSanitizer: false
[task 2023-07-28T00:58:37.488Z] 00:58:37     INFO - REFTEST INFO |     transparentScrollbars: true
[task 2023-07-28T00:58:37.489Z] 00:58:37     INFO - REFTEST INFO |     unsupportedWithDrawSnapshot: false
[task 2023-07-28T00:58:37.489Z] 00:58:37     INFO - REFTEST INFO |     useDrawSnapshot: false
[task 2023-07-28T00:58:37.492Z] 00:58:37     INFO - REFTEST INFO |     usesRepeatResampling: false
[task 2023-07-28T00:58:37.493Z] 00:58:37     INFO - REFTEST INFO |     verify: false
[task 2023-07-28T00:58:37.493Z] 00:58:37     INFO - REFTEST INFO |     webrtc: true
[task 2023-07-28T00:58:37.494Z] 00:58:37     INFO - REFTEST INFO |     winWidget: false
[task 2023-07-28T00:58:37.494Z] 00:58:37     INFO - REFTEST INFO |     xulRuntime: {"widgetToolkit":"gtk","OS":"Linux","XPCOMABI":"x86_64-gcc3"}
[task 2023-07-28T00:58:48.089Z] 00:58:48    ERROR - REFTEST ERROR | EXCEPTION: ReferenceError: getBuildConfiguration is not defined
[task 2023-07-28T00:58:48.091Z] 00:58:48     INFO - REFTEST INFO | Slowest test took 0ms (undefined)
[task 2023-07-28T00:58:48.092Z] 00:58:48     INFO - REFTEST INFO | Total canvas count = 0
Flags: needinfo?(dminor)

Oops, getBuildConfiguration will only be defined in shell builds, I'll update the feature check to skip these tests in jsreftests.

Flags: needinfo?(dminor)
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b59ca147f9d Add feature check for decorators in test262-update.py; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/285b08fe072b Use InternalWhileEmitter in BytecodeEmitter::emitInitializeStaticFields; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/f6d808adb02e Skip tests for private identifiers in decorators; r=mgaudet https://hg.mozilla.org/integration/autoland/rev/65797a3f9a28 Import test262 decorators tests; r=mgaudet
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: