1845614 - Crash when MacAccessibility logging is enabled.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

STR:

Launch firefox with MOZ_LOG=MacAccessibility:5 and VoiceOver.

Firefox will quickly crash because we don't check if mGeckoAccessible is not null when logging.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1845614 - Null check accessible before getting attributes. r?morgan!

Comment 2

[Morgan Reschenberg [:morgan]]

Yayyy :) I ran into this awhile back and forgot to file a bug.

FWIW if you're running a debug build, you'll also fail MOZ_ASSERT(IsText() || IsHyperText()); pretty often when running fx w/ VO on.
This is in RemoteAccessible::GetCachedTextAttributes and accessible/mac/GeckoTextMarker.mm. I'm not sure if there's a bug on file for that ? but the patch I have locally that makes fx debug builds run w/ mac logging includes commenting out those two assertions

Comment 3

[Eitan Isaacson [:eeejay]]

I see an assert failure here: https://searchfox.org/mozilla-central/rev/bf272a7be6fef0e91bde01dfe1f68403d8fbc237/accessible/mac/GeckoTextMarker.mm#458

But it doesn't seem to be related to logging.

Comment 4

[Eitan Isaacson [:eeejay]]

The one in RemoteAccessible::GetCachedTextAttributes also seems to be triggered with MOZ_LOG unset. So I think those assertions should be removed or examined, but they aren't related to logging.

Comment 5

[James Teh [:Jamie]]

Not great, but s4 because this is effectively a debugging only crash.

Comment 6

[Eitan Isaacson [:eeejay]]

(In reply to Morgan Reschenberg [:morgan] from comment #2)

Yayyy :) I ran into this awhile back and forgot to file a bug.

FWIW if you're running a debug build, you'll also fail MOZ_ASSERT(IsText() || IsHyperText()); pretty often when running fx w/ VO on.
This is in RemoteAccessible::GetCachedTextAttributes and accessible/mac/GeckoTextMarker.mm. I'm not sure if there's a bug on file for that ? but the patch I have locally that makes fx debug builds run w/ mac logging includes commenting out those two assertions

So those assertions are actual bugs. I filed bug 1846312 and I'll attach a fix there.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98f16d6c17f8
Null check accessible before getting attributes. r=morgan

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/98f16d6c17f8

Comment 9

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 117.0a1 (2023.07.24) on macOS 12, launch Firefox with command: firefox -p -MOZ_LOG=MacAccessibility:5 and Voice Over on.
Testing on latest nightly 119.0a1 (2023.08.30) with command: firefox -p -MOZ_LOG=MacAccessibility:5 and Voice Over on, Firefox not crashed.
On Firefox 118.0b2 with the same command in the terminal and Voice Over on, Firefox still crashed quickly. It seems that on Fx 118.0b2 the issue is still present.