1845623 - Consider always using non-native rendering for checkboxes and radio buttons on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Our non-native rendering is at least as good, it also fits within windows, and we fall back to it anyways when in dark mode, so we probably should just simplify this code.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1845623 - Remove more dead native appearance values. r=mhowell,handyman

Everytime I look at this code I find more stuff to remove... :)

-moz-default-appearance: groupbox is not used anywhere.

menulist-text is, but it does nothing (it only would prevent drawing a
background, but we don't specify another background anyways).

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1845623 - Make some form controls always non-native on Windows. r=mhowell,handyman,cmartin

In particular, spinner buttons, checkboxes, radio buttons, and the
menulist arrow.

These are all windows-style anyways, and look better than the native
counter-parts because they support webrender, zooming and scaling, etc.

The easiest way to see some of this in action is using ./mach run -P.

Depends on D184647

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/481bfcb7b220
Remove more dead native appearance values. r=mhowell

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f5801ee5897
Fix windows build because of wrongly-split patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f295ceb22674
Regenerate devtools db.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/481bfcb7b220
https://hg.mozilla.org/mozilla-central/rev/6f5801ee5897
https://hg.mozilla.org/mozilla-central/rev/f295ceb22674

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af33198f4756
Make some form controls always non-native on Windows. r=mhowell,desktop-theme-reviewers,dao

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/af33198f4756