1845686 - Mozillabuild (latest version 4.02) has msys directory as msys2, which Windows' build process fails to find the sh.exe

Status: NEW

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

In the past, MozillaBuild's msys directory is "msys".

In 2.53's mozilla-release, python/mozbuild/mozbuild/mozconfig.py has the
following (@ line 247):

    if 'MOZILLABUILD' in os.environ:
        shell = os.environ['MOZILLABUILD'] + '/msys/bin/sh'
    if sys.platform == 'win32':
        shell = shell + '.exe'

With MozillaBuild 4.02, the msys directory is "msys2".

This has been fixed in m-c:
if "MOZILLABUILD" in os.environ:
mozillabuild = os.environ["MOZILLABUILD"]
if (Path(mozillabuild) / "msys2").exists():
shell = mozillabuild + "/msys2/usr/bin/sh"
else:
shell = mozillabuild + "/msys/bin/sh"
prefer_mozillabuild_path = [
os.path.dirname(shell),
str(Path(mozillabuild) / "bin"),
env["PATH"],
]

        env["PATH"] = os.pathsep.join(prefer_mozillabuild_path)

If we are to use MozillaBuild 4.02, this needs to be fixed.

Comment 1

[Frank-Rainer Grahl (:frg)]

Forget it for now. I am on it in time. Needs a ton of backports for the 2.53 line.