1845802 - `mots clean` fails on Windows because of incorrectly defaulting to cp1252

Status: RESOLVED FIXED

(Conduit :: mots, defect)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

> mots clean
2023-07-27 20:29:02,960 config     WARNING  Only synchronizing new people with Bugzilla.
'Nazım'
2023-07-27 20:29:03,057 cli        ERROR    'charmap' codec can't encode character '\u0131' in position 3: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\mots\cli.py", line 299, in main
    args.func(args)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\mots\cli.py", line 70, in clean
    config.clean(file_config, refresh=args.refresh)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\mots\config.py", line 292, in clean
    file_config.write()
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\mots\config.py", line 122, in write
    yaml.dump(self.config, f)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\main.py", line 567, in dump
    return self.dump_all([data], stream, transform=transform)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\main.py", line 577, in dump_all
    self._context_manager.dump(data)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\main.py", line 913, in dump
    self._yaml.representer.represent(data)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\representer.py", line 82, in represent
    self.serializer.serialize(node)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\serializer.py", line 109, in serialize
    self.serialize_node(node, None, None)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\serializer.py", line 225, in serialize_node
    self.serialize_node(value, node, key)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\serializer.py", line 199, in serialize_node
    self.serialize_node(item, node, index)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\serializer.py", line 225, in serialize_node
    self.serialize_node(value, node, key)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\serializer.py", line 165, in serialize_node
    self.emitter.emit(
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 248, in emit
    self.state()
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 704, in expect_block_mapping_simple_value
    self.expect_node(mapping=True)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 411, in expect_node
    self.expect_scalar()
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 468, in expect_scalar
    self.process_scalar()
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 908, in process_scalar
    self.write_plain(self.analysis.scalar, split)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\site-packages\ruamel\yaml\emitter.py", line 1660, in write_plain
    self.stream.write(data)
  File "C:\Users\sasch\AppData\Local\Programs\Python\Python311\Lib\encodings\cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
UnicodeEncodeError: 'charmap' codec can't encode character '\u0131' in position 3: character maps to <undefined>

encoding="utf-8" is missing in config.py.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-conduit/mots] fix: add encoding and newline parameters (bug 1845802) (#76)