184591 - Uninstalling theme removed it from list, but doesn't delete jar

Status: RESOLVED WORKSFORME

(Firefox :: Settings UI, defect, P3)

Description

[Jeremy M. Dolan]

I installed pinball theme from the theme site, but it didn't work right in
Phoenix 0.5. I clicked the uninstall button in the pref pane and it removed it
from there, and it doesn't come back even after restarts, but the jar is still
in my profile:

-rw-r--r--    1 jmd        619452 Dec  9 15:17 pinball_1.0.6_1.2.1.jar

Comment 1

[David P James]

pinball_1.0.6_1.2.1.jar isn't a valid Phoenix theme anyway... that's the Pinball
theme for Mozilla.

But you're right, the jar files aren't deleted. Once you've removed it from the
list you can delete it manually.

-->All OS
-->Minor

Comment 2

[Jeremy M. Dolan]

We should check what happens if you try to reinstall the theme in this
removed-not-deleted state before minoring this. I can try tomorrow.

Comment 3

[David P James]

I already know what it does... :)

It escaped me to mention it though. It appends a -1 to the *newly* installed
theme jar. So if I install my_theme_0.4.jar, then uninstall it without deleting
the file in the chrome directory and then reinstall it I will then have in my
chrome directory:
my_theme_0.4.jar #initially installed
my_theme_0.4-1.jar #reinstalled

I don't know which .jar Phoenix actually uses, but it will display one copy of
that theme in the Themes tab and use it succesfully. Perhaps I should determine
which it is actually using next by modifying the theme ever so slightly prior to
the reinstall (the preview picture for instance).

Comment 4

[David P James]

That was easy - it uses the new jar file, so in the example above it would use

my_theme_0.4-1.jar
in preference to
my_theme_0.4.jar

So yes, this bug can safely remain Minor.

Comment 5

[Chris Cook]

I suggest that the uninstall theme feature _should_ have a confirmation dialog
before removing the theme. This would allow that the dialog _could_ have an
option (checkbox or something) to remove the theme jar if the option is selected.

Requesting confirmation on removing things is generally good practice IMHO.

Comment 6

[Mike Connor [:mconnor]]

taking

Comment 7

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 8

[Mike Connor [:mconnor]]

not visible to users, clearing to post-1.0

Comment 9

[Mike Connor [:mconnor]]

extension manager handles this now.

Comment 10

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change