1845911 - Support expected mapping between unlimitedStorage extension permission to persistent-storage WebAPI permission on Android

Status: RESOLVED FIXED

(WebExtensions :: Android, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The test covering this expected behavior is the test_ext_unlimitedStorage.html mochitest, which is currently disabled on Android builds, disabled for GeckoView in Bug 1615329.

The underlying issue is similar to the one behind test_ext_geolocation.html being disabled, tracked by Bug 1336194 (and in particular see Bug 1336194 comment 15), but unlike geolocation, persistent-storage doesn't require the embedder app to be requesting the related Android permission as it is needed for geolocation (see Bug 1336194 comment 16).

And so in for the mapping between "unlimitedStorage" extension permission and the related "persistent-storage" WebAPI permission, we could technically check if the permission have been granted already to the extension principal and short cut the check by allowing it right away if it is.

This bug is tracking looking into the changes to do that in the GeckoView JSWindow actor layer and re-enabling on GeckoView builds this mochitest to explicitly cover the expected behavior also on the GeckoView builds.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1845911 - Ensure unlimitedStorage extension permission grants persistent-storage WebAPI permission on GeckoView as it does on Desktop builds.

Depends on D184641

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try:

• https://treeherder.mozilla.org/jobs?repo=try&revision=93c5896faaf0b8f8b33bebafb5f14279ec7c69b7

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rpl, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1845911 - Ensure unlimitedStorage extension permission grants persistent-storage WebAPI permission on GeckoView as it does on Desktop builds.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba8757a723af
Ensure unlimitedStorage extension permission grants persistent-storage WebAPI permission on GeckoView as it does on Desktop builds. r=geckoview-reviewers,owlish,robwu

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ba8757a723af