1846036 - Replace usages of deprecated nsILoginManager::findLogins

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Comment 1

[Neil Deakin]

Attachment: Bug 1846036, replace usage of findLogins with searchLoginsAsync, r?#credential-management-reviewers

One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b463b9cd8aef
replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/421628bd5a5c1cf8c64cb86994b1e6dc738abb49

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_prompt.html | Checking returned password - got null, expected "secret"

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2125dc1611be
replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2125dc1611be

Comment 6

[Neil Deakin]

I had to check in some cases using searchLogins instead of searchLoginsAsync due to bug 1848682.

Comment 7

[Pascal Chevrel:pascalc]

Backed out changeset 2125dc1611be (bug 1846036) for causing bug 1852236
https://hg.mozilla.org/releases/mozilla-beta/rev/24d2ddc46990