1846052 - Manifestparser generating tons of log spam in `mach taskgraph`

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

STR:

./mach taskgraph full --target-kind test

Result:
A ton of logs are generated from manifestparser. To an extent that task generation takes noticeably longer just due to all the printing that is happening.

Expected:
Manifestparser does not emit any logs.

I suspect this is a regression from bug 1779473 which had some logging related changes.

Comment 1

[Andrew Halberstadt [:ahal]]

This will likely make Decision tasks slower as well.

Tom, do you think we could revert just the logging portions of your patch?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779473

Comment 3

[Andrew Halberstadt [:ahal]]

Here's a recent Decision task log:
https://firefoxci.taskcluster-artifacts.net/EBAhmN88RcOHHPbWb1RuGw/0/public/logs/live_backing.log

Which is mostly just manifestparser log spam.

Comment 4

[Tom Marble]

Attachment: Bug 1846052 - Reduce manifestparser logging level to DEBUG r=ahal

Comment 5

[Tom Marble]

(In reply to Andrew Halberstadt [:ahal] from comment #1)

This will likely make Decision tasks slower as well.

Tom, do you think we could revert just the logging portions of your patch?

Yes, in this patch I have lowered the logging level from INFO to DEBUG.

https://phabricator.services.mozilla.com/D184892

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779473

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80892e88c552
Reduce manifestparser logging level to DEBUG r=ahal

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/80892e88c552

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tmarble, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Tom Marble]

I do not think this requires an uplift (I could not change status-firefox-117).

Comment 11

[Andrew Halberstadt [:ahal]]

I think we might as well uplift. The extra logs make debugging things annoying.

Comment 12

[Andrew Halberstadt [:ahal]]

Comment on attachment 9346405 [details]
Bug 1846052 - Reduce manifestparser logging level to DEBUG r=ahal

Beta/Release Uplift Approval Request

• User impact if declined: Decision task logs will be very large and difficult to debug
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9346405 [details]
Bug 1846052 - Reduce manifestparser logging level to DEBUG r=ahal

Approved for 117.0b3.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f53c5e7e4d70