1846068 - `./mach busted file <command>` is not working correctly

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect, P3)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

This was a footnote in bug 1845365 which I almost missed, and since that bug is closed, I'll just create a new one here:

(In reply to Jonathan Kew [:jfkthame] from comment #0)

(In addition, ./mach busted file wpt, as recommended by the error message, fails with

wpt is not a valid value for against. against must be the name of a mach command, or else the string "general".

hence filing this in General.)

This was caused by bug 1695312 because not all modules are loaded anymore, but ./mach busted depends on the command_handlers in Registrar, and since they aren't loaded, it fails.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1846068 - Load all command modules for `./mach busted` r?#build

Since it depends on the command_handlers from Registrar for the
file sub_command to determine the appropriate component, we need to
load all command modules so that we can file against any of them.

Depends on D184852

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1695312

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1695312

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd6f3d21ce3f
Load all command modules for `./mach busted` r=firefox-build-system-reviewers,glandium

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fd6f3d21ce3f

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:ahochheiden, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/edbfa38873a7