1846261 - Editing autocompleted domains in URL bar is broken

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[giul.mus]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Suppose that you want to go to "amazonaws.com" and take advantage of the autocompletion "amazon.com".

1. Begin typing a domain in the URL bar: "ama"
2. Verify that the domain is autocompleted to "amazon.com/"
3. Press right arrow to accept the autocompletion, then press the left arrow until the cursor is right at the end of the word "amazon"
4. Type "aws"

Actual results:

The autocompletion, as well as the first letter "a", disappears: I see "ama". If I continue typing, characters after the first will be appended. The final result is "amaws".

Expected results:

The final result is "amazonaws.com/"

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have managed to reproduce this issue on the latest Nightly 117.a1 build (Build ID: 20230730210800) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.

This seems to be a regression and using the mozregression tool I got the following results:

• Last good revision: e4e50bbcb3a212ef8c30c6065b8e9ea5866fac64
• First bad revision: 498b4ed438a3b4e20a618ef3a1c0c5cd0c64cb11
• Pushlog: Link

It seems that this issue was introduced by Bug 1416881.
@Marc could you please take a look at this issue?

Comment 2

[Marc Seibert (:mseibert)]

Attachment: Bug 1846261 - Editing autocompleted domains in URL bar is broken.r=mak

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1416881

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8a68edde94f
Editing autocompleted domains in URL bar is broken.r=mak

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c8a68edde94f

Comment 6

[Marco Bonardo [:mak]]

Attachment: Bug 1846261 - Editing autocompleted domains in URL bar is broken.r=mak

Original Revision: https://phabricator.services.mozilla.com/D185051

Comment 7

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: yes
• Is Android affected?: no
• Steps to reproduce for manual QE testing: The steps are in the bug, it would be useful to test in general editing in the input field after the typed text has been autofilled (e.g. mo[zilla.com]) moving the cursor both with keyboard and mouse.
• Code covered by automated testing: yes
• User impact if declined: editing autofilled text in the address bar is malfunctioning
• String changes made/needed: none
• Fix verified in Nightly: no
• Explanation of risk level: the change is limited to the autofill feature, it would be low after QA checks
• Risk associated with taking this patch: low-medium

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9348351 [details]
Bug 1846261 - Editing autocompleted domains in URL bar is broken.r=mak

Approved for 117.0b6

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/21c1a6306679

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-07-31 Nightly build on macOS 12.
Verified as fixed on Firefox 117.0b6(build ID: 20230810181819) and Nightly 118.0a1(build ID: 20230810094725) on macOS 12, Windows 10, Ubuntu 22.
Editing an autofilled domain in the Address Bar now works as intended.