1846293 - Improve flush handling on canvas2d.

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1846293 - Improve flush handing in Canvas2D. r=jfkthame,dholbert

Don't keep weak pointers before flushing.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b470d886c2f0
Improve flush handing in Canvas2D. r=dholbert

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b470d886c2f0

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9346504 [details]
Bug 1846293 - Improve flush handing in Canvas2D. r=jfkthame,dholbert

Beta/Release Uplift Approval Request

• User impact if declined: potential crashes, see blocked bug
• Is this code covered by automated tests?: Yo
• Has the fix been verified in Nightly?: Via crash analysis data in the blocked bug
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple, very targeted fix.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9346504 [details]
Bug 1846293 - Improve flush handing in Canvas2D. r=jfkthame,dholbert

Approved for 117.0b7

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/864c4a6598aa

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9346504 [details]
Bug 1846293 - Improve flush handing in Canvas2D. r=jfkthame,dholbert

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes bug 1812597
• User impact if declined: crashes
• Fix Landed on Version: 117.0b7
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple fix, no more crash :)

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 10

[Pascal Chevrel:pascalc]

Emilio, the patch does not graft cleanly to the ESR branch, could you provide a patch for the branch please? Thanks!

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: ESR patch

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9352256 [details] [diff] [review]
ESR patch

Approved for ESR 115.3, thanks.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/135c8a58eee1

Comment 14

[Wayne Mery (:wsmwk)]

Crash is gone for Thunderbird and Firefox 118.

Looks like the patch got picked up in Firefox esr 115.2.1, and will thus be in Thunderbird 115.2.2. And so far, after 15+ hours?, of Firefox esr 115.2.1 there are no reports on crash-stats.

Comment 15

[Wayne Mery (:wsmwk)]

Perhaps I miscalculated, but this was still a strong crash for Thunderbird 115.2.2. Too early to see about 115.3.0
https://crash-stats.mozilla.org/signature/?signature=gfxFontGroup%3A%3ASetUserFontSet&date=%3E%3D2023-09-20T10%3A00%3A00.000Z&date=%3C2023-09-27T10%3A00%3A00.000Z#summary

And also still there for Firefox esr 115.2.1, but none so far for 115.3.0?
https://crash-stats.mozilla.org/signature/?product=Firefox&signature=gfxFontGroup%3A%3ASetUserFontSet&date=%3E%3D2023-08-27T10%3A08%3A00.000Z&date=%3C2023-09-27T10%3A08%3A00.000Z#summary

Comment 16

[Wayne Mery (:wsmwk)]

Definitely gone for Thunderbird starting at 115.3.0