184644 - Go -> History doesn't become checked when History sidebar is open

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[piers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3a) Gecko/20021207 Phoenix/0.5

There are two menu items for history, one in View -> Sidebar -> History and one
in Go -> History. The one in Go -> History doesn't get checked/unchecked when
the history siderbar is opened/closed. The other one works as expected.

Reproducible: Always

Steps to Reproduce:
1. Click Go -> History to open the sidebar.
2. Click Go.

Actual Results:  
The History item is not checked.

Expected Results:  
History is checked. Alternatively, remove this entry point to history altogether
since there is already another way to access it (View -> Sidebar -> History).

Comment 1

[David P James]

Confirmed on Linux 20021209

-->OS to All
-->New

Comment 2

[Simon Paquet [:sipaq]]

Taking QA Contact as designated owner of Firebird-Menus. Sorry for bugspam.

Comment 3

[Pham]

OS all?
Win2000 wfm

Comment 4

[Simon Paquet [:sipaq]]

I still see this on W2K.
But we should consider two things:

1. Do we really need this menu entry?
   As the reporter pointed out, it is also accessible via View->Sidebar
   What makes the history so special, that there is no Go->Bookmarks or 
   Go->Downloads?

   Recommendation:
   New Summary: Remove history-entry from Go-Menu

2. Do we need a checkmark here?
   I think not. The Go-Menu is very different from the View-Menu. In the 
   View-Menu we need a checkmark signify the current view-state of a sidebar. In
   the Go-Menu we do not need this.

   Recommendation:
   Resolution: INVALID

Comments?

Comment 5

[Pham]

I think remove Go>History is better because IE doesn't have it and it's weird to
have a menu item on top, links in middle, and menus on bottom

And there's a random bug(I don't do random bugs) where separator is visible and
sometimes not between site and History
and if you remove Go>History then there's no separator and no random bug

Comment 6

[Mike Connor [:mconnor]]

I'd say lets get rid of it entirely, we don't need a fourth entry method, do we?

Comment 7

[José Jeria]

Is this really necessary? I vote for removing. Easier(?) and less bloat. 

Comment 8

[David P James]

Ok, that makes 3 QAs and at least one triager in favour of removal. I think that
we've got ourselves a quorum here :)

Comment 9

[Mike Connor [:mconnor]]

on second thought, I'd rather drop View->Sidebars

Comment 10

[Samir L. Boulema]

i go for drop the Go->History

Comment 11

[Ivan Ičin]

If there should be Go -> History menu, it should not have check. Actual bug is
that it closes History bar, while I would expect it to open History or bring
focus to it if it has been already opened

Comment 12

[R.J. Keller]

Attachment: Patch - Adds observer to History menu item under Go menu

looks like a quick fix, so here it is :).

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 156309 [details] [diff] [review]
Patch - Adds observer to History menu item under Go menu

works for me

Comment 14

[Asa Dotzler [:asa]]

Comment on attachment 156309 [details] [diff] [review]
Patch - Adds observer to History menu item under Go menu

a=asa for branch checkin.

Comment 15

[Mike Connor [:mconnor]]

landed on aviary branch, RJ can check this in himself on trunk, I don't have a
clean trunk tree atm

Comment 16

[Steffen Wilberg]

Fixed on trunk by the branch landing.