Closed Bug 1846500 Opened 2 years ago Closed 2 years ago

Inherit PrefersColorSchemeOverride for chrome windows with opener relationship

Categories

(Firefox :: Theme, task)

Product:
Firefox
Component:
Theme
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
118 Branch
Tracking Flags:
Tracking Status
firefox118 --- fixed

People

(Reporter: emz, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1846500 - Inherit color scheme override from opener. r=pbz
48 bytes, text/x-phabricator-request
Details | Review

We use prefersColorSchemeOverride to apply dark theme to only Private Browsing Mode windows. This has led to edge cases like Bug 1844346 where child windows opened from PBM windows don't have the override applied.

For Bug 1844346 we resolved the issue by manually migrating the prefersColorSchemeOverride state from the opener window in cert manager / pageinfo code. However ideally we can add this inheritance to our BrowsingContext code directly. See comments here: https://bugzilla.mozilla.org/show_bug.cgi?id=1844346#c6

Depends on: 1749377
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/276cf96e94e0 Inherit color scheme override from opener. r=pbz

https://hg.mozilla.org/mozilla-central/rev/276cf96e94e0

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Regressions: 1866022
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: