Closed
Bug 1846545
Opened 2 years ago
Closed 2 years ago
Update card-container to use 'pageName' and 'showViewAll' properties
Categories
(Firefox :: Firefox View, task)
Firefox
Firefox View
Tracking
()
RESOLVED
FIXED
118 Branch
Tracking | Status | |
---|---|---|
firefox118 | --- | fixed |
People
(Reporter: kcochrane, Assigned: kcochrane)
References
Details
(Whiteboard: [fidefe-firefox-view])
Attachments
(1 file)
In the card-container component, we are relying on a viewAllPage
property to set the open/closed state pref:
https://searchfox.org/mozilla-central/source/browser/components/firefoxview/card-container.mjs#49
We should still be able to store this pref if the 'View all' link isn't present (such as when the empty state is shown for that card). A user may, for example, not use sync and want to always keep that card collapsed on the Recent browsing page.
We should remove the viewAllPage
property and replace it with two new properties:
shortPageName
that takes a string value exactly as theviewAllPage
ones were setshowViewAll
that's a boolean used to hide/show the 'View all' link
The shortPageName
property can the be used for the open/closed state pref if on the Recent browsing page as well as for the 'View all' link if showViewAll
is set to true.
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•2 years ago
|
||
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f07d1564dc0
Update card-container to use 'pageName' and 'showViewAll' properties r=mkaply,fxview-reviewers,sclements
Comment 3•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•