1846677 - vaapitest isnt installed on non-wayland but glxtest tries to run it

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Landry Breuil (:gaston)]

maybe related to bug 1833354 and/or bug 1787182 ?

starting firefox 117.0b1 on OpenBSD which is X11-only for now (MOZ_WAYLAND is false) there's MOZ_ENABLE_VAAPI=1, so i get those errors on stderr:

Crash Annotation GraphicsCriticalError: |[0][GFX1-]: vaapitest: ManageChildProcess failed
 (t=1.55172) [GFX1-]: vaapitest: ManageChildProcess failed

vaapitest binary isnt shipped because of https://searchfox.org/mozilla-central/source/browser/installer/package-manifest.in#115 being within #ifdef MOZ_WAYLAND ?

the binary is built, i can manually try to run it but it tries to dlopen an inexisting library:

$./vaapitest -d /dev/dri/renderD128
ERROR
VA-API test failed: libva-drm.so.2 is missing.

i dunno if the latter is wayland-only.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

VA-API/V4L2 was enabled for X11 builds too.

It should be

#ifdef MOZ_WAYLAND
@BINPATH@/@DLL_PREFIX@mozwayland@DLL_SUFFIX@
#endif

i.e. we apply to mozwayland only.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1846677 [Linux] Don't restrict v4l2test/vaapitest shipping to Wayland only r?emilio

Comment 3

[Landry Breuil (:gaston)]

thanks, with https://phabricator.services.mozilla.com/D185131 on 117.0b2 i now get the 'expected' failure:

(#0) Error	vaapitest: ERROR
(#1) Error	vaapitest: VA-API test failed: libva-drm.so.2 is missing. 

guess i'll locally patch it so that it returns a failure early to avoid spamming the console, until we have a libva-drm port somewhere...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc6121a69859
[Linux] Don't restrict v4l2test/vaapitest shipping to Wayland only r=emilio

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fc6121a69859

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9346852 [details]
Bug 1846677 [Linux] Don't restrict v4l2test/vaapitest shipping to Wayland only r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Custom Firefox builds may be built without HW acceleration. Does not affects Mozilla binaries.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Build configuration fix to install gfx probe binaries on X11 only builds.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9346852 [details]
Bug 1846677 [Linux] Don't restrict v4l2test/vaapitest shipping to Wayland only r?emilio

Approved for 117.0b4

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/600425a20e1e

Comment 10

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #9)

https://hg.mozilla.org/releases/mozilla-beta/rev/600425a20e1e

== Change summary for alert #39264 (as of Thu, 10 Aug 2023 17:46:01 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	Images	macosx1015-64-shippable-qr	fission tp6	5,924,126.13 -> 5,728,742.22

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39264