1846680 - Update libpng to new version v1.7.0beta89 from 2017-08-19 01:22:58

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, enhancement)

Description

[Update Bot]

This update covers 781 commits. Here are the overall diff statistics, and then the commit information.

---

media/libpng/ANNOUNCE | 1464 +++-
media/libpng/AUTHORS | 50 -
media/libpng/CHANGES | 2183 +--
media/libpng/LICENSE | 174 +-
media/libpng/README | 234 +-
media/libpng/TRADEMARK | 8 -
media/libpng/arm/arm_init.c | 139 -
media/libpng/arm/filter_neon.S | 259 -
media/libpng/arm/filter_neon_intrinsics.c | 402 -
media/libpng/arm/linux.c | 14 +-
media/libpng/arm/palette_neon_intrinsics.c | 151 -
media/libpng/intel/filter_sse2_intrinsics.c | 391 -
media/libpng/intel/intel_init.c | 52 -
media/libpng/libpng-manual.txt | 721 +-
media/libpng/mips/filter_msa_intrinsics.c | 808 -
media/libpng/mips/mips_init.c | 130 -
media/libpng/moz.build | 10 -
media/libpng/moz.yaml | 2 +-
media/libpng/png.c | 2089 +---
media/libpng/png.h | 2189 +++-
media/libpng/pngconf.h | 77 +-
media/libpng/pngdebug.h | 13 +-
media/libpng/pngerror.c | 556 +-
media/libpng/pngget.c | 341 +-
media/libpng/pnginfo.h | 57 +-
media/libpng/pngmem.c | 83 +-
media/libpng/pngpread.c | 1727 +--
media/libpng/pngpriv.h | 2263 ++--
media/libpng/pngread.c | 2325 ++--
media/libpng/pngrio.c | 64 +-
media/libpng/pngrtran.c | 11412 ++++++++++++++----------
media/libpng/pngrutil.c | 5496 +++++------
media/libpng/pngset.c | 876 +-
media/libpng/pngstruct.h | 1003 +-
media/libpng/pngtrans.c | 4376 +++++++-
media/libpng/pngwio.c | 110 +-
media/libpng/pngwrite.c | 2159 ++--
media/libpng/pngwtran.c | 609 +-
media/libpng/pngwutil.c | 5998 ++++++++----
media/libpng/powerpc/filter_vsx_intrinsics.c | 768 -
media/libpng/powerpc/powerpc_init.c | 126 -
41 files changed, 27562 insertions(+), 24347 deletions(-)

---

781 commits elided, as they are too long for a bugzilla comment.

---

Comment 2

[Update Bot]

./mach vendor media/libpng/moz.yaml reported an error editing moz.build files:

Latest tag is v1.7.0beta89 from 2017-08-19T01:22:58Z
Fetching code archive from https://github.com/glennrp/libpng/archive/v1.7.0beta89.tar.gz
Retaining wanted in-tree files.
Cleaning media/libpng to import changes.
Unpacking upstream files for media/libpng.
Retaining wanted files from upstream changes.
Removing excluded files from upstream changes.
Removing: [66 (omitted) items in /tmp/tmps4ndgdli/scripts, 20 (omitted) items in /tmp/tmps4ndgdli, 3 items in /tmp/tmps4ndgdli/contrib: README.txt, extensions.ac and extensions.am, 40 (omitted) items in /tmp/tmps4ndgdli/tests, 3 items in /tmp/tmps4ndgdli/contrib/arm-neon: README, linux-auxv.c and android-ndk.c, 106 (omitted) items in /tmp/tmps4ndgdli/contrib/testpngs, 21 (omitted) items in /tmp/tmps4ndgdli/contrib/gregbook, 16 (omitted) items in /tmp/tmps4ndgdli/contrib/tools, 12 (omitted) items in /tmp/tmps4ndgdli/contrib/pngminus, 11 (omitted) items in /tmp/tmps4ndgdli/contrib/visupng, 31 (omitted) items in /tmp/tmps4ndgdli/contrib/pngsuite, 6 items in /tmp/tmps4ndgdli/projects/owatcom: pngvalid.tgt, pngtest.tgt, libpng.tgt, pngstest.tgt, libpng.wpj and pngconfig.mak, /tmp/tmps4ndgdli/projects/vstudio/zlib/zlib.vcxproj, 11 (omitted) items in /tmp/tmps4ndgdli/contrib/libtests, 4 items in /tmp/tmps4ndgdli/contrib/pngminim/preader: pngusr.h, makefile, README and pngusr.dfa, 7 items in /tmp/tmps4ndgdli/contrib/conftest: write.dfa, README, read.dfa, simple.dfa, s_write.dfa, pngcp.dfa and s_read.dfa, 4 items in /tmp/tmps4ndgdli/contrib/pngminim/decoder: README, pngusr.dfa, makefile and pngusr.h, /tmp/tmps4ndgdli/contrib/pngminim/README, 9 items in /tmp/tmps4ndgdli/contrib/neon: neon.am, filter_neon_intrinsics.c, filter_neon.S, neon.ac, extensions.ac, neon.h, neon.dfa, extensions.am and arm_init.c, /tmp/tmps4ndgdli/projects/vstudio/pngunknown/pngunknown.vcxproj, 3 items in /tmp/tmps4ndgdli/projects/vstudio: zlib.props, vstudio.sln and README.txt, 5 items in /tmp/tmps4ndgdli/contrib/examples: pngpixel.c, simpleover.c, README.txt, iccfrompng.c and pngtopng.c, 4 items in /tmp/tmps4ndgdli/contrib/pngminim/encoder: pngusr.h, README, makefile and pngusr.dfa, 7 items in /tmp/tmps4ndgdli/projects/visualc71: zlib.vcproj, libpng.vcproj, PRJ0041.mak, README_zlib.txt, pngtest.vcproj, libpng.sln and README.txt, /tmp/tmps4ndgdli/projects/vstudio/pngvalid/pngvalid.vcxproj, /tmp/tmps4ndgdli/projects/vstudio/pngtest/pngtest.vcxproj, /tmp/tmps4ndgdli/projects/vstudio/pnglibconf/pnglibconf.vcxproj, /tmp/tmps4ndgdli/projects/vstudio/pngstest/pngstest.vcxproj, /tmp/tmps4ndgdli/projects/vstudio/libpng/libpng.vcxproj]
Copying to media/libpng.
Checking for update actions
action: copy-file src: /builds/worker/checkouts/gecko/media/libpng/contrib/arm-neon/linux.c dst: /builds/worker/checkouts/gecko/media/libpng/arm/linux.c
action: delete-path path: /builds/worker/checkouts/gecko/media/libpng/contrib
Registering changes with version control.
Checking for a spurious update.
Version 'v1.7.0beta89' has changed 39 files.
Updating moz.yaml.
Found release: commit v1.6.39 (2022-11-20T23:53:23+02:00).

Found revision: "v1.6.39"

Updating moz.build files
Found 0 files added and 12 files removed.
Could not remove media/libpng/AUTHORS from the appropriate moz.build file
Could not remove media/libpng/TRADEMARK from the appropriate moz.build file
This is a deficiency in ./mach vendor . Please review the affected files before committing.

We're going to continue processing the update; but we may fail because we couldn't handle these files. If we do succeed, you may want to add these files to the 'exclude' key in the moz.yaml file, so they are excluded from the source tree and ignored in the future.

Comment 3

[Update Bot]

Updatebot encountered an error while trying to apply the mozilla patches. with the following message:

stdout:
Importing local patches...
patch -p1 --directory media/libpng --input /builds/worker/checkouts/gecko/media/libpng/1737038.patch --no-backup-if-mismatch
patching file pngwutil.c
Hunk #1 FAILED at 336.
Hunk #2 FAILED at 828.
2 out of 2 hunks FAILED -- saving rejects to file pngwutil.c.rej
Error running mach:

mach vendor --patch-mode only media/libpng/moz.yaml

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ./mach busted to check if this issue is already on file. If it
isn't, please use ./mach busted file vendor to report it. If ./mach busted is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Process executed with non-0 exit code 1: ['patch', '-p1', '--directory', 'media/libpng', '--input', '/builds/worker/checkouts/gecko/media/libpng/1737038.patch', '--no-backup-if-mismatch']

File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/mach_commands.py", line 131, in vendor
vendor_command.vendor(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 116, in vendor
self.import_local_patches(
File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/vendor/vendor_manifest.py", line 834, in import_local_patches
self.run_process(
File "/builds/worker/checkouts/gecko/python/mach/mach/mixin/process.py", line 190, in run_process
raise Exception(

Updatebot will be unable to do anything more for this library version.

Comment 4

[Timothy Nikkel (:tnikkel)]

Are you the right person to needinfo for update bot issues?

"v1.7.0beta89 from 2017-08-19" seems to be an old dead branch.