1846740 - [wdspec] Some screenshot clip tests fail because of comparing float with integer values

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Currently some tests for browsingContext.screenshot with the clip argument fail because the compared values are floats and not integers. Affected tests are test_clip_viewport and test_clip_element.

Here the failure message:

FAIL message: assert (190, 23) == (190.6666717529297, 23)

Affected tests use the get_physical_element_dimensions() helper to retrieve the element dimension. While the documentation says it returns integers: Tuple of (int, int) it's not the fact.

https://searchfox.org/mozilla-central/rev/0816653c3ab851fa0e362eaec48c643fb764eaf4/testing/web-platform/tests/webdriver/tests/bidi/browsing_context/capture_screenshot/__init__.py#50-60

For us the failures started when the clipping tests have been added via bug 1840998.

Most likely we have to floor the value when comparing with the PNG dimensions.

Note it doesn't seem to be an issue in our own CI but on Github the test fails.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1846740 - [wdspec] get_physical_element_dimensions has to return integer numbers and not float.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d86212d5deaf
[wdspec] get_physical_element_dimensions has to return integer numbers and not float. r=webdriver-reviewers,jdescottes

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41335 for changes under testing/web-platform/tests

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d86212d5deaf

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham