1846855 - mach taskgraph test-action-callback fails due to hardcoded source dir path

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Rob Lemley [:rjl]]

Attempted to run:
./mach taskgraph test-action-callback --input /tmp/action.json --task-group-id <decision id> -p ~/Downloads/parameters.yml --root comm/taskcluster/ci release-promotion

It mostly runs, except towards the end it fails:

0:19.35 writing artifact file `label-to-taskid.json`
Traceback (most recent call last):
  File "/home/rob/moz/m-b/taskcluster/gecko_taskgraph/main.py", line 747, in test_action_callback
    return gecko_taskgraph.actions.trigger_action_callback(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/rob/moz/m-b/taskcluster/gecko_taskgraph/actions/registry.py", line 356, in trigger_action_callback
    cb(Parameters(**parameters), graph_config, input, task_group_id, task_id)
  File "/home/rob/moz/m-b/taskcluster/gecko_taskgraph/actions/release_promotion.py", line 427, in release_promotion_action
    taskgraph_decision({"root": graph_config.root_dir}, parameters=parameters)
  File "/home/rob/moz/m-b/taskcluster/gecko_taskgraph/decision.py", line 282, in taskgraph_decision
    shutil.copy2(run_task_file_path, ARTIFACTS_DIR)
  File "/usr/lib/python3.11/shutil.py", line 436, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.11/shutil.py", line 256, in copyfile
    with open(src, 'rb') as fsrc:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/builds/worker/checkouts/gecko/taskcluster/scripts/run-task'

That path does not exist on my development machine, so obviously will fail.

There's a hardcoded path at:
https://searchfox.org/mozilla-central/rev/2bf90dc51ce7e8274ce208fbb9d68b3ff535185e/taskcluster/gecko_taskgraph/decision.py#278

Should be easily replaced with GECKO for the actual checkout root.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1846855 - Replace hardcoded source path with GECKO for testing action callbacks. r=#taskgraph-reviewers

Normally the taskgraph_decision code is not run outside of CI, but when using
mach test-action-callback locally it is used. The hardcoded path is problematic
when doing so.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38cb294e6cb0
Replace hardcoded source path with GECKO for testing action callbacks. r=taskgraph-reviewers,bhearsum

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/38cb294e6cb0